Do not try to download Chromium by default #2364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This happens because the wordpress/scripts package depends on Puppeteer, which results in attempts to download Chromium when running `npm install`. Once we use Puppeteer for end-to-end tests that can be run on Travis, we can enable the download again just for that stage. Related: WordPress/gutenberg#15712
|
The directory where Chromium is being downloaded to could also be added to the list of cached directories. |
westonruter
approved these changes
May 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This happens because the wordpress/scripts package depends on Puppeteer, which results in attempts to download Chromium when running
npm install.Once we use Puppeteer for end-to-end tests that can be run on Travis, we can enable the download again just for that stage. Until then, setting
PUPPETEER_SKIP_CHROMIUM_DOWNLOAD=trueshould make Travis jobs a bit faster.Related: #2363, WordPress/gutenberg#15712