Add support for capturing requests and responses for test data generation #341
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kelsonpw
reviewed
Sep 6, 2023
| }; | ||
| }; | ||
|
|
||
| const cookieName = 'amp_store_requests_for_test_data'; |
There was a problem hiding this comment.
given this is a public package on NPM, do you think there is value in adding this in a configurable way? perhaps more broadly scoped cookie name at the very least?
There was a problem hiding this comment.
Yeah, I'll change the 'amp' prefix!
kelsonpw
approved these changes
Sep 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for capturing requests and responses made through redux-query, for use as test data. The capturing will only occur if the cookie
amp_store_requests_for_test_datais set totrue. If that cookie is enabled, two functions are made available on the window:getRequestsForTestData- returns the object including rest and gql requests and their responsesclearRequestsForTestData- resets the request object to be empty, in case the user wants to isolate request capturing to one area of the app.Loom explanation of the bigger picture: https://www.loom.com/share/c20ca7a364244578bb742d687469a1d5