This repository was archived by the owner on Mar 30, 2023. It is now read-only.
Open
Conversation
|
I think we should fix the underlying problem considering how little amplitude communicates. |
Author
I think we should replace these lifecycle methods. We should use But, that should be properly tested. So, before making that change I think we should just use the |
|
Can this be merged soon so I stop seeing warnings? :) |
sebdec
approved these changes
Sep 30, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
componentWillMount and componentWillReceiveProps are not recommended to use. From React 17.x, only the UNSAFE_ name will work. UNSAFE alias was introduced in React version 16.3.
Had to also disable eslint for camelcase rule.
In the future, we can use componentDidMount instead of componentWillMount and componentDidUpdate instead of componentWillReceiveProps.