Fix handling of booleans in conditions #35
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Booleans are currently handled very poorly.
Especially when the context contains real
true
orfalse
booleans.The Amplitude UI often shows
True
andFalse
as auto completions.Since this SDK uses
strval
to convert a boolean to a string value, a booleantrue
becomes string1
. And booleanfalse
becomes string0
.But if the flag's condition uses string
True
orFalse
, it won't match.To solve this, we add more test cases, and refactor the
matchesIs
in the EvaluationEngine.I also tried to add the following test cases:
But these fail because they are intercepted and handled as nullables:
experiment-php-server/src/EvaluationCore/EvaluationEngine.php
Lines 84 to 89 in 3527848
While inspecting the code responsible for that, I really think this Evaluation Engine shouldn't have been made loosely typed but strictly typed instead 🤯