Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(session replay): rrweb changes require a few modifications to the SDK #906

Merged
merged 4 commits into from
Oct 29, 2024
Merged

chore(session replay): rrweb changes require a few modifications to the SDK #906

merged 4 commits into from
Oct 29, 2024

Conversation

jxiwang
Copy link

@jxiwang jxiwang commented Oct 25, 2024

Summary

rrweb upgrades resulted in some modifications needed to how certain functions are imported.

Checklist

  • Does your PR title have the correct title format?
  • Does your PR have a breaking change?:

lewgordon-amplitude
lewgordon-amplitude approved these changes Oct 28, 2024
View reviewed changes
Copy link

@lewgordon-amplitude lewgordon-amplitude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

packages/session-replay-browser/src/hooks/click.ts Outdated Show resolved Hide resolved
@jxiwang jxiwang merged commit 2067dc9 into v1.x Oct 29, 2024
4 checks passed
@jxiwang jxiwang deleted the AMP-95748 branch October 29, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lewgordon-amplitude lewgordon-amplitude lewgordon-amplitude approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jxiwang @lewgordon-amplitude