fix(plugin-network-autocapture): replace consumption check with cache #1274
+12
−40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniel-graham-amplitude
changed the title
jxiwang
approved these changes
Aug 26, 2025
daniel-graham-amplitude
deleted the
AMP-137112/add-caching-to-headers-and-body
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The consumption checker is a problem if 2+ instances of Amplitude are on a website, because it will consume body and headers 2+ times and cause an error to be thrown.
Replacing the consumption checker with a body cache for fetch that caches the body response to prevent cloning from happening 2x.
Checklist