Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump sshd-core from 2.0.0 to 2.7.0 in /oda-subsystems/sshserver #13

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dependabot[bot]
Copy link

@dependabot dependabot bot commented on behalf of github Feb 17, 2022

Bumps sshd-core from 2.0.0 to 2.7.0.

Changelog

Sourced from sshd-core's changelog.

Version 2.6.0 to 2.7.0

Version 2.7.0 to 2.8.0

Planned for next version

Major code re-factoring

Potential compatibility issues

Changes that may affect existing code

A new SFTP configuration property has been introduced that limits the maximum amount of data that can be sent in a single SSH_FXP_WRITE packet - default=256KB

    /**
     * Force the use of a max. packet length for {@link AbstractSftpSubsystemHelper#doWrite(Buffer, int)} protection
     * against malicious packets
     */
    public static final Property<Integer> MAX_WRITE_DATA_PACKET_LENGTH
            = Property.integer("sftp-max-writedata-packet-length", 256 * 1024);

This might cause SFTP write failures for clients that might have sent larger buffers and they have been accepted so far. If this happens, simply increase this value (though the choice of 256KB should be compatible with the vast majority of clients).

SSH channel identifiers have been changed to use long instead of int in order to align them with the standard that required them to be UINT32 values.

The relevant API(s) have been modified accordingly - which may cause a few incompatibility issues with code that extends/implements existing Channel classes and interfaces. In this context, the Channel interface now extends ChannelIdentifier where getId() has been renamed to getChannelId()

long used instead of int in most encoded/decoded packets that are specified as being UINT32

There are several exceptions to this rule:

  • The SFTP packet id field - an "opaque" value anyway, not used for allocation or indexing anyway

  • Various flags and mask field - there is no reason to encapsulate them into a long value since they do not represent a cardinal number of 32 bits

  • Various status code fields - ditto.

  • Cases where the value serves as argument for allocation of other data structures based on its value - e.g., arrays, lists. This was done for convenience reasons since Java does not support unsigned array/list sizes. In such cases, special validation code was applied to make sure the requested value does not exceed Integer#MAX_VALUE (sometimes even less) in order to protect the code from malicious or malformed packets. It is important to bear in mind that in the vast majority of the cases we do not want to be able to allocate arrays or lists having billions of elements as it would almost definitely cause out-of-memory issues.

Minor code helpers

Behavioral changes and enhancements

... (truncated)

Commits
  • 2772c7c [maven-release-plugin] prepare release sshd-2.7.0
  • c5500e9 Add changelog for 2.7.0
  • 9a724be [SSHD-525] Server side implementation of posix-rename@openssh.com
  • 4dad0d7 [SSHD-1145] Deprecate ReflectionUtils#isClassAvailable and use ThreadUtils#re...
  • db7cbdc [SSHD-1158] Don't send channel EOF after having received channel CLOSE
  • 60b50f9 [SSHD-1141] DefaultClientKexExtensionHandler: ensure list is modifiable
  • 797d887 Updated Netty version to 4.1.63
  • 4bfeca3 Updated PMD version to 6.33.0
  • f7a2ae3 Updated Checkstyle version to 8.41.1
  • 0a3f5da Updated Spring Core version to 5.3.6
  • Additional commits viewable in compare view

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

> **Note** > Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Feb 17, 2022
@dependabot dependabot bot force-pushed the dependabot/maven/oda-subsystems/sshserver/org.apache.sshd-sshd-core-2.7.0 branch 2 times, most recently from 684f1aa to f093355 Compare February 17, 2022 09:36
@dependabot dependabot bot force-pushed the dependabot/maven/oda-subsystems/sshserver/org.apache.sshd-sshd-core-2.7.0 branch from f093355 to 0db2679 Compare February 17, 2022 10:36
@dependabot dependabot bot force-pushed the dependabot/maven/oda-subsystems/sshserver/org.apache.sshd-sshd-core-2.7.0 branch from 0db2679 to 3386817 Compare February 17, 2022 11:07
Bumps [sshd-core](https://github.com/apache/mina-sshd) from 2.0.0 to 2.7.0.
- [Release notes](https://github.com/apache/mina-sshd/releases)
- [Changelog](https://github.com/apache/mina-sshd/blob/master/CHANGES.md)
- [Commits](apache/mina-sshd@sshd-2.0.0...sshd-2.7.0)

---
updated-dependencies:
- dependency-name: org.apache.sshd:sshd-core
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/maven/oda-subsystems/sshserver/org.apache.sshd-sshd-core-2.7.0 branch from 3386817 to c319044 Compare February 17, 2022 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants