Refactor rebase function parameters to separate positive and negative growth #297
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor rebase function parameters to separate positive and negative growth
🚨 Report Summary
For more details view the full report in OpenZeppelin Code Inspector |
brandoniles
approved these changes
Mar 25, 2025
aalavandhan
reviewed
Apr 1, 2025
| int256 public rebaseFunctionLowerPercentage; | ||
| int256 public rebaseFunctionUpperPercentage; | ||
| int256 public rebaseFunctionGrowth; | ||
| int256 public rebaseFunctionNegativePercentageLimit; |
There was a problem hiding this comment.
Here we are basically renaming 3 storage variables and adding one more. Changes look upgrade safe. 👍
We can use the /// @custom:oz-renamed-from operator natspec comment to keep track of pervious names. It helps the oz upgrade tooling keep track of the storage state ..
https://github.com/ampleforth/ampleforth-contracts/blob/master/.openzeppelin/mainnet.json#L155
https://forum.openzeppelin.com/t/rename-struct-property/38519/4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.