Merged
Conversation
aalavandhan
commented
Oct 4, 2023
| using UInt256Lib for uint256; | ||
|
|
||
| /// @notice DEPRECATED. | ||
| event LogRebase( |
Member
Author
There was a problem hiding this comment.
We need to update and redeploy the subgraph index based on either LogRebase and Rebase.
aalavandhan
force-pushed
the
target-fix
branch
2 times, most recently
from
ca56426 to
ad58b29
Compare
ahnaguib
requested changes
Oct 4, 2023
contracts/UFragmentsPolicy.sol
Outdated
Comment on lines
136
to
139
| uint256 currentRate; | ||
| bool currentRateValid; | ||
| (currentRate, currentRateValid) = marketOracle.getData(); | ||
| require(currentRateValid); |
Contributor
There was a problem hiding this comment.
can we keep names as is :) ?
aalavandhan
force-pushed
the
target-fix
branch
2 times, most recently
from
3403bb9 to
3296e35
Compare
brandoniles
reviewed
Oct 4, 2023
aalavandhan
force-pushed
the
target-fix
branch
2 times, most recently
from
fd5d900 to
cf50107
Compare
nms-7
approved these changes
Oct 5, 2023
brandoniles
reviewed
Oct 5, 2023
ahnaguib
reviewed
Oct 5, 2023
| uint256 reportDelaySec_, | ||
| uint256 minimumProviders_ | ||
| uint256 minimumProviders_, | ||
| uint256 scalar_ |
Contributor
There was a problem hiding this comment.
Thinking about this more I think we need different scalar for different providers when using different sources for target price (we can do that in a later change though)
ahnaguib
approved these changes
Oct 5, 2023
Co-authored-by: Brandon Iles <brandon.iles@gmail.com>
aalavandhan
force-pushed
the
target-fix
branch
from
a7b2581 to
6800a35
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
output = median*scalar