-
Notifications
You must be signed in to change notification settings - Fork 1
[ENG-2552] feat: confirm if read schedules should be stopped when installations exist for an integration #243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds confirmation prompts when deploying integrations that have removed read objects from their YAML configuration, warning users that active read schedules for those objects will be stopped.
Key changes:
- Added functionality to detect removed read objects by comparing old and new integration manifests
- Implemented user confirmation prompts that display affected installations
- Enhanced the deploy command to check for removed objects before proceeding with deployment
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
File | Description |
---|---|
files/zip.go | Added ReadManifestFile function to extract manifest content from zip sources |
files/manifest.go | Added GetRemovedReadObjects function to compare old and new integrations for removed read objects |
files/manifest_test.go | Added comprehensive test coverage for the GetRemovedReadObjects function |
cmd/deploy.go | Enhanced deploy command with confirmation logic and user prompting for removed read objects |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please modify the output to look like the following? (note the additional empty lines)
You are removing the following read action object(s) from integration 'readSalesforce': contacts, leads.
Any active scheduled reads for these objects will be stopped.
This integration has 12 installation(s).
- Acme Corp (acme-corp)
- FooBar Inc (foo-bar)
- and 10 more
Do you still want to deploy a new revision of this integration? [y/N]
e8e0557
to
1d66973
Compare
Description
When a builder removes read objects from an integration YAML, we now show a confirmation prompt before deploying. This gives them a heads-up that any active read schedules for those objects will be stopped.
What it looks like:
The above prompt will repeat for each integration that they are removing read objects for.
Changes
Testing