Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix latest "inspect" bug by adding manual Vercel Project Name option #29

Merged
merged 3 commits into from
Aug 12, 2020

Conversation

EvanLovely
Copy link
Contributor

This would resolve #27 & #28 by sidestepping the need to even run vercel inspect as that is only needed to get the Vercel Project Name - this PR adds the ability to manually set vercel-project-name inside the GitHub Actions yaml config. Let me know if there's anything else needed for this to get in! Thanks!

index.js Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Aug 10, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@klapec
Copy link

klapec commented Aug 12, 2020

Is there anything blocking this pull request from being merged (aside from the checks, I guess?)
vercel-action is currently useless as it fails on the vercel inspect command.

@simonhaenisch
Copy link

simonhaenisch commented Aug 12, 2020

Got this email yesterday

Hello,

The issue has been fixed for all new deployments. We are working to make it compatible with old deployments as well.

Can you confirm?

Best Regards,
~ Paulo De Mitri @ Vercel

Copy link
Owner

@amondnet amondnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for late.
LGTM

@amondnet amondnet merged commit 73f4fc9 into amondnet:master Aug 12, 2020
@amondnet amondnet added this to the v19.0.1+3 milestone Aug 12, 2020
@amondnet amondnet linked an issue Aug 12, 2020 that may be closed by this pull request
@amondnet amondnet mentioned this pull request Aug 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deploy is failing Deployment succeeds but action log says it failed
4 participants