Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use scope everywhere npx is used #24

Merged
merged 4 commits into from
Aug 12, 2020
Merged

fix: use scope everywhere npx is used #24

merged 4 commits into from
Aug 12, 2020

Conversation

aulneau
Copy link
Contributor

@aulneau aulneau commented Jul 27, 2020

This uses the scope anytime the npx vercel command is issued. This allows for domains to be aliased that are owned by a team, vs a single user.

@aulneau aulneau mentioned this pull request Jul 27, 2020
Closed
@sonarcloud
Copy link

sonarcloud bot commented Jul 28, 2020

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
11.7% 11.7% Duplication

@amondnet amondnet added this to the v19.0.1+3 milestone Aug 12, 2020
@amondnet amondnet self-requested a review August 12, 2020 14:18
amondnet
amondnet approved these changes Aug 12, 2020
View reviewed changes
Copy link
Owner

@amondnet amondnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amondnet amondnet merged commit 08a788c into amondnet:master Aug 12, 2020
@amondnet amondnet linked an issue Aug 12, 2020 that may be closed by this pull request
Alias does not incorporate scope #23
Closed
@amondnet amondnet mentioned this pull request Aug 13, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amondnet amondnet amondnet approved these changes

Assignees
No one assigned
Labels
Priority: High Type: Bug Bug or Bug fixes
Projects
None yet
Milestone
v19.0.1+3
Development

Successfully merging this pull request may close these issues.

Alias does not incorporate scope
2 participants
@aulneau @amondnet