-
-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow spaces in vercel-args #237
Conversation
Deploy preview for zeit-now-deployment-action-example-static ready! ✅ Preview Built with commit 2225a57. |
Deploy preview for team-scope-test ready! ✅ Preview Built with commit 2225a57. |
Deploy preview for vercel-action-example-nextjs ready! ✅ Preview Built with commit 2225a57. |
Kudos, SonarCloud Quality Gate passed! |
@@ -32887,6 +32906,7 @@ async function aliasDomainsToDeployment(deploymentUrl) { | |||
} | |||
|
|||
async function run() { | |||
core.info('Does it really run ????????????????????????'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this a leftover from a debugging session? 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LOL, I didn't package the script
I said npm run package
is annoying....
Thanks @rpartridge, until the release you can use a commit pin as follows in your workflow: - name: Deploy
uses: amondnet/vercel-action@8433ae13f35aa62d68184a8fc369ce6b0143b0a3 |
Splitting arguments and preserving the behavior of quotes will finally allow us to use spaces in vercel-args 🎉
Solve #236
Thanks for making MORE explicit the necessity to run
npm run package
to rebuild the package, I've wasted hours debugging this....