Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow spaces in vercel-args #237

Merged
merged 4 commits into from
Oct 14, 2023
Merged

feat: allow spaces in vercel-args #237

merged 4 commits into from
Oct 14, 2023

Conversation

skyf0l
Copy link
Contributor

@skyf0l skyf0l commented Oct 13, 2023

Splitting arguments and preserving the behavior of quotes will finally allow us to use spaces in vercel-args 🎉

Solve #236

Thanks for making MORE explicit the necessity to run npm run package to rebuild the package, I've wasted hours debugging this....

@github-actions
Copy link

github-actions bot commented Oct 13, 2023

Deploy preview for zeit-now-deployment-action-example-static ready!

✅ Preview
https://zeit-now-deployment-action-example-static-g1k1ayscp-amond.vercel.app
https://staging.static.vercel-action.amond.dev
https://pr-237.static.vercel-action.amond.dev

Built with commit 2225a57.
This pull request is being automatically deployed with vercel-action

@github-actions
Copy link

github-actions bot commented Oct 13, 2023

Deploy preview for team-scope-test ready!

✅ Preview
https://team-scope-test-i6j4ingpm-dietfriends.vercel.app

Built with commit 2225a57.
This pull request is being automatically deployed with vercel-action

@github-actions
Copy link

github-actions bot commented Oct 13, 2023

Deploy preview for vercel-action-example-nextjs ready!

✅ Preview
https://vercel-action-example-nextjs-7jwau16cu-amond.vercel.app
https://staging.nextjs.vercel-action.amond.dev
https://pr-237.nextjs.vercel-action.amond.dev

Built with commit 2225a57.
This pull request is being automatically deployed with vercel-action

@sonarcloud
Copy link

sonarcloud bot commented Oct 14, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@amondnet amondnet merged commit f790839 into amondnet:master Oct 14, 2023
5 of 9 checks passed
@@ -32887,6 +32906,7 @@ async function aliasDomainsToDeployment(deploymentUrl) {
}

async function run() {
core.info('Does it really run ????????????????????????');
Copy link

@nasso nasso Oct 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this a leftover from a debugging session? 😅

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LOL, I didn't package the script
I said npm run package is annoying....

@skyf0l skyf0l mentioned this pull request Oct 14, 2023
@rpartridge
Copy link

Hey @amondnet and @skyf0l , thanks for fixing this issue! Are there plans to include this in a future release? I see there hasn't been a release since January 2023 before this PR was merged. Thanks in advance

@skyf0l
Copy link
Contributor Author

skyf0l commented Jan 11, 2024

Thanks @rpartridge, until the release you can use a commit pin as follows in your workflow:

      - name: Deploy
        uses: amondnet/vercel-action@8433ae13f35aa62d68184a8fc369ce6b0143b0a3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants