Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: branch is undefined #33

Merged
merged 22 commits into from
Apr 4, 2020
Merged

fix: branch is undefined #33

merged 22 commits into from
Apr 4, 2020

Conversation

amondnet
Copy link
Owner

fix #31

@amondnet amondnet added the Type: Bug Bug or Bug fixes label Feb 25, 2020
@amondnet amondnet added this to the v2.0.2 milestone Feb 25, 2020
@amondnet amondnet self-assigned this Feb 25, 2020
@github-actions
Copy link

Deploy preview for website ready!

Built with commit 426b582

https://public-2de3ygqzf.now.sh

1 similar comment
@github-actions
Copy link

Deploy preview for website ready!

Built with commit 426b582

https://public-2de3ygqzf.now.sh

@github-actions
Copy link

Deploy preview for website ready!

Built with commit 61ed708

https://public-6goxms1kx.now.sh

1 similar comment
@github-actions
Copy link

Deploy preview for website ready!

Built with commit 61ed708

https://public-6goxms1kx.now.sh

@github-actions
Copy link

Deploy preview for website ready!

Built with commit 8d4608a

https://public-pkc492yp7.now.sh

1 similar comment
@github-actions
Copy link

Deploy preview for website ready!

Built with commit 8d4608a

https://public-pkc492yp7.now.sh

@github-actions
Copy link

Deploy preview for website ready!

Built with commit 60f83c1

https://public-em6ajgqpr.now.sh

1 similar comment
@github-actions
Copy link

Deploy preview for website ready!

Built with commit 60f83c1

https://public-em6ajgqpr.now.sh

@richardvclam
Copy link

No rush, but would love to get this merged 😄

@amondnet
Copy link
Owner Author

@richardvclam Sorry for late. I will take time to release it soon.

You could use this temporarily.
https://help.github.com/en/actions/reference/context-and-expression-syntax-for-github-actions

Context name Type Description
github.ref string The branch or tag ref that triggered the workflow run.
github.head_ref string The head_ref or source branch of the pull request in a workflow run. This property is only available when the event that triggers a workflow run is a pull_request.
github.base_ref string The base_ref or target branch of the pull request in a workflow run. This property is only available when the event that triggers a workflow run is a pull_request.
      - uses: amondnet/now-deployment@v2
        env:
          BRANCH: ${{ github.base_ref }}
        with:
          zeit-token: ${{ secrets.ZEIT_TOKEN }} # Required
          github-token: ${{ secrets.GITHUB_TOKEN }} #Optional
          now-org-id: ${{ secrets.ORG_ID}} #Required
          now-project-id: ${{ secrets.PROJECT_ID}} #Required
          now-args: "-m githubCommitRef=$BRANCH"

@github-actions
Copy link

github-actions bot commented Apr 4, 2020

This pull request is being automatically deployed with now-deployment

Built with commit refs/pull/33/merge

✅ Preview: https://public-c0nnk0bur.now.sh

@github-actions
Copy link

github-actions bot commented Apr 4, 2020

This pull request is being automatically deployed with now-deployment

Built with commit refs/pull/33/merge

✅ Preview: https://zeit-now-deployment-action-example-angular-ihvtazm89.now.sh

@github-actions
Copy link

github-actions bot commented Apr 4, 2020

This pull request is being automatically deployed with now-deployment

Built with commit refs/pull/33/merge

✅ Preview: https://public-c0nnk0bur.now.sh

@github-actions
Copy link

github-actions bot commented Apr 4, 2020

This pull request is being automatically deployed with now-deployment

Built with commit refs/pull/33/merge

✅ Preview: https://zeit-now-deployment-action-example-angular-ihvtazm89.now.sh

@github-actions
Copy link

github-actions bot commented Apr 4, 2020

This pull request is being automatically deployed with now-deployment

Built with commit refs/pull/33/merge

✅ Preview: https://public-c0nnk0bur.now.sh

@github-actions
Copy link

github-actions bot commented Apr 4, 2020

This pull request is being automatically deployed with now-deployment

Built with commit refs/pull/33/merge

✅ Preview: https://zeit-now-deployment-action-example-angular-ihvtazm89.now.sh

@github-actions
Copy link

github-actions bot commented Apr 4, 2020

This pull request is being automatically deployed with now-deployment

Built with commit hotfix/branch-undefined

✅ Preview: https://public-c0nnk0bur.now.sh

@github-actions
Copy link

github-actions bot commented Apr 4, 2020

This pull request is being automatically deployed with now-deployment

Built with commit hotfix/branch-undefined

✅ Preview: https://zeit-now-deployment-action-example-angular-ihvtazm89.now.sh

@github-actions
Copy link

github-actions bot commented Apr 4, 2020

This pull request is being automatically deployed with now-deployment

Built with commit hotfix/branch-undefined

✅ Preview: https://public-c0nnk0bur.now.sh

@github-actions
Copy link

github-actions bot commented Apr 4, 2020

This pull request is being automatically deployed with now-deployment

Built with commit hotfix/branch-undefined

✅ Preview: https://zeit-now-deployment-action-example-angular-ihvtazm89.now.sh

@github-actions
Copy link

github-actions bot commented Apr 4, 2020

This pull request is being automatically deployed with now-deployment

Built with commit hotfix/branch-undefined

✅ Preview: https://public-c0nnk0bur.now.sh

@github-actions
Copy link

github-actions bot commented Apr 4, 2020

This pull request is being automatically deployed with now-deployment

Built with commit hotfix/branch-undefined

✅ Preview: https://zeit-now-deployment-action-example-angular-ihvtazm89.now.sh

@github-actions
Copy link

github-actions bot commented Apr 4, 2020

This pull request is being automatically deployed with now-deployment

Built with commit hotfix/branch-undefined

✅ Preview: https://public-c0nnk0bur.now.sh

@github-actions
Copy link

github-actions bot commented Apr 4, 2020

This pull request is being automatically deployed with now-deployment

Built with commit hotfix/branch-undefined

✅ Preview: https://zeit-now-deployment-action-example-angular-ihvtazm89.now.sh

@github-actions
Copy link

github-actions bot commented Apr 4, 2020

This pull request is being automatically deployed with now-deployment

Built with commit hotfix/branch-undefined

✅ Preview: https://public-c0nnk0bur.now.sh

@github-actions
Copy link

github-actions bot commented Apr 4, 2020

This pull request is being automatically deployed with now-deployment

Built with commit hotfix/branch-undefined

✅ Preview: https://zeit-now-deployment-action-example-angular-ihvtazm89.now.sh

@github-actions
Copy link

github-actions bot commented Apr 4, 2020

This pull request is being automatically deployed with now-deployment

Built with commit c3080c6

✅ Preview: https://public-c0nnk0bur.now.sh

@github-actions
Copy link

github-actions bot commented Apr 4, 2020

This pull request is being automatically deployed with now-deployment

Built with commit c3080c6

✅ Preview: https://zeit-now-deployment-action-example-angular-ihvtazm89.now.sh

@amondnet amondnet merged commit 740d8b5 into master Apr 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Bug or Bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Branch is undefined
2 participants