-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Outputs object is always empty #25
Comments
Also ran into that issue. Its only set if comment on commit or pull is enabled. |
@peterschrott I owe you a ☕, works beautifully. @amondnet will leave this open for you as it seems you add the bug label (and the bug without the PR comment enabled could still exist)...but for now @peterschrott solved the issue at hand. Thanks all 🥇 |
output is only set if comment on commit or pull is enabled. fix #25
@followbl |
@amondnet tested this right when you ping'ed me and then forgot to comment. unfortunately for me the output is empty still if I take away |
@amondnet Looks like the issue with getting the preview url can be solved quite easily since the preview url is the only thing stored in the https://github.com/hakonkrogh/now-deployment I can create a pull request for this if you want to. |
@hakonkrogh Yes, I would appreciate it. |
|
Is there anything I'm doing wrong here? I'm having trouble accessing the output from the now-deployment step...found adding the id to the step in the forums, but still no luck. Any assistance if I'm missing something simple is appreciated.
The text was updated successfully, but these errors were encountered: