This repository was archived by the owner on Mar 4, 2025. It is now read-only.
typescript version added, javascript version fixed #15
Open
andrea-calabretta wants to merge 2 commits intoamnesty:masterfrom
Open
typescript version added, javascript version fixed #15andrea-calabretta wants to merge 2 commits intoamnesty:masterfrom
andrea-calabretta wants to merge 2 commits intoamnesty:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the previous JavaScript version, IBAN with more same letters (for example double 'T' like in IT07T0200817105000102728777) were not validated because in the "replaceLetterWithDigits" function, the replacement stopped at the first occurrence of the letter, leaving the other letters unreplaced.
In the version I'm proposing, I fixed it and I added the TypeScript version too.
Thank you.