Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add timezone to the user profile #127

Closed
wants to merge 10 commits into from
Closed

add timezone to the user profile #127

wants to merge 10 commits into from

Conversation

mnglkhn
Copy link

@mnglkhn mnglkhn commented Jan 20, 2016

The user is able to select a timezone to his/her profile.
This is useful when users are on different timezone and need to have date/time info displayed in their timezone.

@@ -31,7 +31,7 @@ class Module extends \yii\base\Module
/**
* @var bool If true, users are required to enter a username
*/
public $requireUsername = false;
public $requireUsername = true;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This probably slipped into your commit, I don't think the author will want to default to a required username.

@amnah
Copy link
Owner

amnah commented Jan 20, 2016

This is awesome! I'll look into getting it in tonight, thanks so much!

@mnglkhn
Copy link
Author

mnglkhn commented Jan 20, 2016

I just realized that it is a patch to the ^3.0.0 branch
But the changes can be easily brought forward to the current branch

@mnglkhn mnglkhn closed this Jan 20, 2016
@mnglkhn
Copy link
Author

mnglkhn commented Jan 20, 2016

closed by mistake; please feel free to reopen

@amnah amnah reopened this Jan 20, 2016
amnah added a commit that referenced this pull request Jan 23, 2016
@amnah
Copy link
Owner

amnah commented Jan 23, 2016

Just added this in manually. Thanks again!!

@amnah amnah closed this Jan 23, 2016
@mnglkhn
Copy link
Author

mnglkhn commented Jan 23, 2016

the dropdown list is rather long and it would be nice to use Kartik's
Select2 widget.
Not sure if you want to introduce a dependency but maybe a short
readme/hint would also help.

On Fri, Jan 22, 2016 at 9:12 PM, amnah notifications@github.com wrote:

Closed #127 #127.


Reply to this email directly or view it on GitHub
#127 (comment).

@amnah
Copy link
Owner

amnah commented Jan 23, 2016

Ya, I don't really want to add anymore to this - my goal is to keep this module simple and basic. Note/comment added da5fa76

@mnglkhn mnglkhn deleted the mnglkhn-add_timezone branch February 1, 2016 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants