Reducers #2
Reducers #2
Conversation
There was a problem hiding this comment.
Hi @amklass11 👋 ,
Good job so far!
You still need to work on some issues to go to the next project, but you are almost there!
Highlights
- No linter errors 🟢
- Good commit messages ㊗️
- Nice use of git-flow ✔️
Required Changes ♻️
- Kindly , you should fix the broken link of license in README file to make your project look professional .you can use different licenses like MIT ,etc.
Check the comments under the review.
Optional suggestions
[Optional] I recommend using redux-logger middleware to check your application logs. you can do so by this command npm i --save redux-logger.
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
action and reducers