Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace python-requests with urllib.request #717

Merged
merged 2 commits into from
Nov 21, 2022

Conversation

elliotwutingfeng
Copy link
Contributor

Changes

Replaced python-requests with urllib.request from the standard library; for simple GET requests, both urllib and requests are equal in terms of boilerplate and performance, so this saves us the extra step of pip install requests.

README.md has been updated accordingly.

@amix
Copy link
Owner

amix commented Nov 21, 2022

I appreciate this, @elliotwutingfeng 🙏

@amix amix merged commit 09d062a into amix:master Nov 21, 2022
@elliotwutingfeng elliotwutingfeng deleted the request branch November 21, 2022 09:48
201341 pushed a commit to 201341/vimrc that referenced this pull request Nov 14, 2023
panard313 pushed a commit to panard313/amix_vimrc that referenced this pull request Nov 27, 2023
* 'master' of https://github.com/amix/vimrc: (138 commits)
  Replace Unicode dashes with ASCII ones (amix#722)
  Update README.md (amix#728)
  Fix autocommand error when opening command line window (amix#731)
  Fix support for native vim packages (amix#733)
  Add short info on colorscheme setup (amix#734)
  Updated plugins
  Updated nerdtree plugin
  Updated plugins
  Disable ale_virtualtext_cursor
  Added Github Copilot plugin
  Updated plugins
  Updated vim plugins
  Change Unicode dash in basic.vim#3 to ASCII one (amix#720)
  Replace python-requests with urllib.request (amix#717)
  Remove jedi-vim
  Updated plugins
  Update README.md
  Formatting updated in the packloadall section
  Fix amix#658
  Fix amix#680
  ...
panard313 pushed a commit to panard313/amix_vimrc that referenced this pull request Nov 27, 2023
* amix-master: (139 commits)
  Title: Add proxy ofr update_plugins.py
  Replace Unicode dashes with ASCII ones (amix#722)
  Update README.md (amix#728)
  Fix autocommand error when opening command line window (amix#731)
  Fix support for native vim packages (amix#733)
  Add short info on colorscheme setup (amix#734)
  Updated plugins
  Updated nerdtree plugin
  Updated plugins
  Disable ale_virtualtext_cursor
  Added Github Copilot plugin
  Updated plugins
  Updated vim plugins
  Change Unicode dash in basic.vim#3 to ASCII one (amix#720)
  Replace python-requests with urllib.request (amix#717)
  Remove jedi-vim
  Updated plugins
  Update README.md
  Formatting updated in the packloadall section
  Fix amix#658
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants