AP_Filesystem: correct comparison of signed/unsigned

Closes ArduPilot#14267
amitjoshi438 · May 4, 2020 · f43e48a · f43e48a
1 parent ebc781b
commit f43e48a
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/libraries/AP_Filesystem/AP_Filesystem_ROMFS.cpp b/libraries/AP_Filesystem/AP_Filesystem_ROMFS.cpp
@@ -97,7 +97,11 @@ int32_t AP_Filesystem_ROMFS::lseek(int fd, int32_t offset, int seek_from)
     }
     switch (seek_from) {
     case SEEK_SET:
-        file[fd].ofs = MIN(file[fd].size, offset);
+        if (offset < 0) {
+            errno = EINVAL;
+            return -1;
+        }
+        file[fd].ofs = MIN(file[fd].size, (uint32_t)offset);
         break;
     case SEEK_CUR:
         file[fd].ofs = MIN(file[fd].size, offset+file[fd].ofs);