Skip to content

feat: implements support for custom container names #3197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 13, 2024

Conversation

Jeto143
Copy link
Contributor

@Jeto143 Jeto143 commented Aug 13, 2024

This introduces the ability to customize a container's name by adding a dev.dozzle.name label to it.

Related issue:
#3189

@Jeto143 Jeto143 changed the title Implement support for custom container names feat: implement support for custom container names Aug 13, 2024
@Jeto143 Jeto143 changed the title feat: implement support for custom container names feat: implements support for custom container names Aug 13, 2024
@amir20
Copy link
Owner

amir20 commented Aug 13, 2024

Nice. And updated docs too 🚀

@amir20 amir20 merged commit acbb2a8 into amir20:master Aug 13, 2024
7 of 8 checks passed
@amir20
Copy link
Owner

amir20 commented Aug 13, 2024

@Jeto143 quick favor. When developing Dozzle for the first time, were the instructions at https://github.com/amir20/dozzle?tab=readme-ov-file#building enough? Let me know if that should be updated.

@Jeto143
Copy link
Contributor Author

Jeto143 commented Aug 13, 2024

@Jeto143 quick favor. When developing Dozzle for the first time, were the instructions at https://github.com/amir20/dozzle?tab=readme-ov-file#building enough? Let me know if that should be updated.

Sure! First a quick disclaimer, I have never developed in Go before (even though I've wanted to learn it for quite some time). I use MacOS and IntelliJ IDEA.

The process overall went well but I had to do a few things that weren't mentioned in the README (for most of them they probably shouldn't anyway, see below):

  1. Had to add $(go env GOPATH)/bin:$PATH to my PATH after installing reflex. This shouldn't need to be added to the README as I'm sure it's common knowledge and not specific at all to this project.
  2. Had to enable Go modules after importing the project inside IntelliJ so that it could understand the github.com/* imports. This is IDE-specific and shouldn't need to be added either.
  3. I had to manually run make build (vite build) once, otherwise the startup process (make dev) would fail with [backend] [00] main.go:28:12: pattern all:dist: no matching files found. This one might need your attention as I'm assuming we shouldn't need to build assets manually during development. If you have a dist folder locally and remove it you might be able to reproduce this.
  4. When running make dev, my browser opens automatically on http://localhost:5173 but the page sometimes fails to load ("localhost refused to connect") for a few seconds (I guess until it can load all the containers etc). It's really no big deal at all, but the first time it happened I didn't notice and thought something was wrong.

Hope this'll help!

@amir20
Copy link
Owner

amir20 commented Aug 13, 2024

Ah nice. That's good. I'll update make dev to also depend on auto generated files.

On 4, that's because the browser is opening but the Go binary is still compiling. I am not sure of a better solution.

@Jeto143 Jeto143 deleted the custom-container-names branch August 16, 2024 08:47
renovate bot referenced this pull request in NorkzYT/Wolflith Aug 17, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Update | Change | Pending |
|---|---|---|---|
| [amir20/dozzle](https://togithub.com/amir20/dozzle) | minor | `v8.1.5`
-> `v8.2.0` | `v8.2.1` |

---

### Release Notes

<details>
<summary>amir20/dozzle (amir20/dozzle)</summary>

### [`v8.2.0`](https://togithub.com/amir20/dozzle/releases/tag/v8.2.0)

[Compare
Source](https://togithub.com/amir20/dozzle/compare/v8.1.5...v8.2.0)

#####    🚀 Features

- Implements support for custom container names  -  by
[@&#8203;Jeto143](https://togithub.com/Jeto143) in
[https://github.com/amir20/dozzle/issues/3197](https://togithub.com/amir20/dozzle/issues/3197)
[<samp>(acbb2)</samp>](https://togithub.com/amir20/dozzle/commit/acbb2a8d)
- Reads certs locally if available  -  by
[@&#8203;amir20](https://togithub.com/amir20) in
[https://github.com/amir20/dozzle/issues/3196](https://togithub.com/amir20/dozzle/issues/3196)
[<samp>(7f735)</samp>](https://togithub.com/amir20/dozzle/commit/7f735d26)

#####     [View changes on
GitHub](https://togithub.com/amir20/dozzle/compare/v8.1.5...v8.2.0)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "after 10pm every weekday,every
weekend,before 5am every weekday" in timezone America/New_York,
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR was generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View the
[repository job log](https://developer.mend.io/github/NorkzYT/Wolflith).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4yNi4xIiwidXBkYXRlZEluVmVyIjoiMzguMjYuMSIsInRhcmdldEJyYW5jaCI6InN0YWdpbmciLCJsYWJlbHMiOlsiZGVwZW5kZW5jaWVzIiwibWlub3IiLCJyZW5vdmF0ZSJdfQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants