Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix JSON export trailing comma #843

Merged
merged 3 commits into from
Oct 24, 2024
Merged

Fix JSON export trailing comma #843

merged 3 commits into from
Oct 24, 2024

Conversation

jbrendel
Copy link
Contributor

This is a fix for issue #842

@jbrendel jbrendel mentioned this pull request Oct 23, 2024
Closed
2 tasks
aminalaee
aminalaee requested changes Oct 23, 2024
View reviewed changes
sqladmin/models.py Outdated Show resolved Hide resolved
aminalaee
aminalaee approved these changes Oct 24, 2024
View reviewed changes
Copy link
Owner

@aminalaee aminalaee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR 👍

@aminalaee aminalaee changed the title Fix: Trailing comma after last entry of JSON export Fix JSON export trailing comma Oct 24, 2024
@aminalaee aminalaee merged commit e2f84cc into aminalaee:main Oct 24, 2024
5 checks passed
@aminalaee aminalaee mentioned this pull request Oct 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aminalaee aminalaee aminalaee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jbrendel @aminalaee