Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove fixable and add meta.type #305

Merged
merged 1 commit into from
Apr 11, 2020
Merged

Conversation

brettz9
Copy link
Contributor

@brettz9 brettz9 commented Apr 11, 2020

Regarding removal of "fixable", per https://eslint.org/docs/developer-guide/working-with-rules#options-schemas :

Omit the fixable property if the rule is not fixable.

Regarding meta.type, though generally more useful with the likes of eslint --fix-type, besides for general documentation, I'm intending to release an eslint badge formatter which can count total number of violations by type (e.g., 5 problem, 10 suggestion, 4 layout violations).

Regarding removal of "fixable", per https://eslint.org/docs/developer-guide/working-with-rules#options-schemas :

> Omit the fixable property if the rule is not fixable.

Regarding `meta.type`, though generally more useful with the likes of [`eslint --fix-type`](https://eslint.org/docs/user-guide/command-line-interface#fix-type), besides for general documentation, I'm intending to release an eslint badge formatter which can count total number of violations by type (e.g., 5 problem, 10 suggestion, 4 layout violations).
@brettz9 brettz9 changed the title Update compat.js Remove fixable and add meta.type Apr 11, 2020
@amilajack amilajack merged commit 0e6e9fb into amilajack:master Apr 11, 2020
@amilajack
Copy link
Owner

Thanks for this!

@brettz9 brettz9 deleted the patch-1 branch April 11, 2020 15:34
brettz9 added a commit to brettz9/eslint-plugin-compat that referenced this pull request Apr 11, 2020
Regarding removal of "fixable", per https://eslint.org/docs/developer-guide/working-with-rules#options-schemas :

> Omit the fixable property if the rule is not fixable.

Regarding `meta.type`, though generally more useful with the likes of [`eslint --fix-type`](https://eslint.org/docs/user-guide/command-line-interface#fix-type), besides for general documentation, I'm intending to release an eslint badge formatter which can count total number of violations by type (e.g., 5 problem, 10 suggestion, 4 layout violations).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants