-
-
Notifications
You must be signed in to change notification settings - Fork 54
(#127) Image.run() #140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(#127) Image.run() #140
Conversation
Job #140 is now in scope, role is |
Pull Request Test Coverage Report for Build 263
💛 - Coveralls |
This pull request #140 is assigned to @amihaiemil/z, here is why; the budget is 15 minutes, see §4; please, read §27 and when you decide to accept the changes, inform @amihaiemil/z (the architect) right in this ticket; if you decide that this PR should not be accepted ever, also inform the architect; this blog post will help you understand what is expected from a code reviewer; we should be aware that @amihaiemil/z is on vacation; this ticket may be delayed; there will be no monetary reward for this job |
Manual assignment of issues is discouraged, see §19: -5 point(s) just awarded to @amihaiemil/z |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@llorllale looks nice, just one question
URI.create("http://localhost/images/image123"), | ||
DOCKER | ||
).run(), | ||
Matchers.notNullValue() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@llorllale instead of notNullValue()
, can you compare the result of run()
with the mock container
above? It should be the exact same reference, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@amihaiemil done
As per PR review: Fixed assertion in RtImageTestCase.runsItselfOk()
@amihaiemil done, please check |
@rultor merge it |
@amihaiemil OK, I'll try to merge now. You can check the progress of the merge here |
@amihaiemil @llorllale Oops, I failed. You can see the full log here (spent 21s)
|
There is an unrecoverable failure on my side. Please, submit it here:
0.22.22: CID: 1720728111, Type: "Close job", Author: "amihaiemil" |
The job #140 is now out of scope |
For #127:
Image.run()
: basically a shortcut forContainer.create(image); Container.start();
Docker
instance is now passed down throughRtDocker
->RtImages
->RtImage
to enableRtImage
to create containers.