Skip to content

(#127) Image.run() #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 21, 2018
Merged

(#127) Image.run() #140

merged 2 commits into from
Jun 21, 2018

Conversation

llorllale
Copy link
Contributor

For #127:

  • Implemented Image.run(): basically a shortcut for Container.create(image); Container.start();
  • The Docker instance is now passed down through RtDocker -> RtImages -> RtImage to enable RtImage to create containers.

@llorllale llorllale mentioned this pull request Jun 19, 2018
@0crat
Copy link
Collaborator

0crat commented Jun 19, 2018

Job #140 is now in scope, role is REV

@coveralls
Copy link

coveralls commented Jun 19, 2018

Pull Request Test Coverage Report for Build 263

  • 9 of 9 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.3%) to 82.589%

Totals Coverage Status
Change from base Build 261: 0.3%
Covered Lines: 370
Relevant Lines: 448

💛 - Coveralls

@0crat
Copy link
Collaborator

0crat commented Jun 19, 2018

@amihaiemil/z everybody who has role REV is banned at #140; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@amihaiemil amihaiemil self-assigned this Jun 20, 2018
@0crat
Copy link
Collaborator

0crat commented Jun 20, 2018

This pull request #140 is assigned to @amihaiemil/z, here is why; the budget is 15 minutes, see §4; please, read §27 and when you decide to accept the changes, inform @amihaiemil/z (the architect) right in this ticket; if you decide that this PR should not be accepted ever, also inform the architect; this blog post will help you understand what is expected from a code reviewer; we should be aware that @amihaiemil/z is on vacation; this ticket may be delayed; there will be no monetary reward for this job

@0crat
Copy link
Collaborator

0crat commented Jun 20, 2018

Manual assignment of issues is discouraged, see §19: -5 point(s) just awarded to @amihaiemil/z

Copy link
Owner

@amihaiemil amihaiemil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@llorllale looks nice, just one question

URI.create("http://localhost/images/image123"),
DOCKER
).run(),
Matchers.notNullValue()
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@llorllale instead of notNullValue(), can you compare the result of run() with the mock container above? It should be the exact same reference, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per PR review:
Fixed assertion in RtImageTestCase.runsItselfOk()
@llorllale
Copy link
Contributor Author

@amihaiemil done, please check

@amihaiemil
Copy link
Owner

@rultor merge it

@rultor
Copy link
Collaborator

rultor commented Jun 21, 2018

@rultor merge it

@amihaiemil OK, I'll try to merge now. You can check the progress of the merge here

@rultor
Copy link
Collaborator

rultor commented Jun 21, 2018

@rultor merge it

@amihaiemil @llorllale Oops, I failed. You can see the full log here (spent 21s)

+ set -e
+ set -o pipefail
++ dirname ./run.sh
+ cd .
+ echo 23631
+ echo '1.67.4 dbdae7b78'
1.67.4 dbdae7b78
+ date
Thu Jun 21 09:21:26 CEST 2018
+ uptime
 09:21:26 up 37 days, 54 min,  1 user,  load average: 0.84, 0.77, 0.75
+ ff=default
+ image=yegor256/java8
+ rebase=false
+ head_branch=master
./run.sh: line 23: syntax error near unexpected token `('
'cid' file is absent, container wasn't started correctly

@amihaiemil amihaiemil merged commit 263d4a8 into amihaiemil:master Jun 21, 2018
@0crat
Copy link
Collaborator

0crat commented Jun 21, 2018

There is an unrecoverable failure on my side. Please, submit it here:

PID: 4@a0cc108b-284c-417e-b3b4-360e68d85261, thread: AsyncFlush-7
com.zerocracy.farm.sync.SyncProject[77] java.lang.IllegalStateException: Failed to acquire "verbosity/amihaiemil.xml" in "PMO" in 2min: a3e35cd2a8c4/3min/0/6/true/false by QuartzScheduler_Worker-3

0.22.22: CID: 1720728111, Type: "Close job", Author: "amihaiemil"

@0crat
Copy link
Collaborator

0crat commented Jun 25, 2018

@amihaiemil/z everybody who has role REV is banned at #140; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@0crat
Copy link
Collaborator

0crat commented Jun 26, 2018

The job #140 is now out of scope

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants