Skip to content

Container.remove + tests #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 24, 2018
Merged

Container.remove + tests #118

merged 3 commits into from
May 24, 2018

Conversation

amihaiemil
Copy link
Owner

PR for #117

@0crat
Copy link
Collaborator

0crat commented May 17, 2018

Job #118 is now in scope, role is REV

@coveralls
Copy link

coveralls commented May 17, 2018

Pull Request Test Coverage Report for Build 204

  • 13 of 13 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.7%) to 82.647%

Totals Coverage Status
Change from base Build 199: 0.7%
Covered Lines: 281
Relevant Lines: 340

💛 - Coveralls

@0crat
Copy link
Collaborator

0crat commented May 17, 2018

This pull request #118 is assigned to @llorllale/z, here is why; the budget is 15 minutes, see §4; please, read §27 and when you decide to accept the changes, inform @amihaiemil/z (the architect) right in this ticket; if you decide that this PR should not be accepted ever, also inform the architect; this blog post will help you understand what is expected from a code reviewer

@0crat
Copy link
Collaborator

0crat commented May 22, 2018

@llorllale/z this job was assigned to you 5days ago. It will be taken away from you soon, unless you close it, see §8. Read this and this, please.

@llorllale
Copy link
Contributor

@amihaiemil looks good to me

@llorllale
Copy link
Contributor

@rultor merge please

@rultor
Copy link
Collaborator

rultor commented May 23, 2018

@rultor merge please

@llorllale Thanks for your request. @amihaiemil Please confirm this.

@amihaiemil
Copy link
Owner Author

@rultor merge

@rultor
Copy link
Collaborator

rultor commented May 23, 2018

@rultor merge

@amihaiemil OK, I'll try to merge now. You can check the progress of the merge here

@rultor
Copy link
Collaborator

rultor commented May 23, 2018

@rultor merge

@amihaiemil Oops, I failed. You can see the full log here (spent 3min)

[INFO] -------------------------------------------------------------
[ERROR] /home/r/repo/src/test/java/com/amihaiemil/docker/RtContainerTestCase.java:[479,9] constructor RtContainer in class com.amihaiemil.docker.RtContainer cannot be applied to given types;
  required: javax.json.JsonObject,org.apache.http.client.HttpClient,java.net.URI
  found: com.amihaiemil.docker.mock.AssertRequest,java.net.URI
  reason: actual and formal argument lists differ in length
[ERROR] /home/r/repo/src/test/java/com/amihaiemil/docker/RtContainerTestCase.java:[505,9] constructor RtContainer in class com.amihaiemil.docker.RtContainer cannot be applied to given types;
  required: javax.json.JsonObject,org.apache.http.client.HttpClient,java.net.URI
  found: com.amihaiemil.docker.mock.AssertRequest,java.net.URI
  reason: actual and formal argument lists differ in length
[ERROR] /home/r/repo/src/test/java/com/amihaiemil/docker/RtContainerTestCase.java:[521,9] constructor RtContainer in class com.amihaiemil.docker.RtContainer cannot be applied to given types;
  required: javax.json.JsonObject,org.apache.http.client.HttpClient,java.net.URI
  found: com.amihaiemil.docker.mock.AssertRequest,java.net.URI
  reason: actual and formal argument lists differ in length
[ERROR] /home/r/repo/src/test/java/com/amihaiemil/docker/RtContainerTestCase.java:[537,9] constructor RtContainer in class com.amihaiemil.docker.RtContainer cannot be applied to given types;
  required: javax.json.JsonObject,org.apache.http.client.HttpClient,java.net.URI
  found: com.amihaiemil.docker.mock.AssertRequest,java.net.URI
  reason: actual and formal argument lists differ in length
[ERROR] /home/r/repo/src/test/java/com/amihaiemil/docker/RtContainerTestCase.java:[553,9] constructor RtContainer in class com.amihaiemil.docker.RtContainer cannot be applied to given types;
  required: javax.json.JsonObject,org.apache.http.client.HttpClient,java.net.URI
  found: com.amihaiemil.docker.mock.AssertRequest,java.net.URI
  reason: actual and formal argument lists differ in length
[INFO] 5 errors 
[INFO] -------------------------------------------------------------
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 10.158 s
[INFO] Finished at: 2018-05-23T18:56:57+00:00
[INFO] Final Memory: 31M/569M
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.6.0:testCompile (default-testCompile) on project docker-java-api: Compilation failure: Compilation failure:
[ERROR] /home/r/repo/src/test/java/com/amihaiemil/docker/RtContainerTestCase.java:[479,9] constructor RtContainer in class com.amihaiemil.docker.RtContainer cannot be applied to given types;
[ERROR] required: javax.json.JsonObject,org.apache.http.client.HttpClient,java.net.URI
[ERROR] found: com.amihaiemil.docker.mock.AssertRequest,java.net.URI
[ERROR] reason: actual and formal argument lists differ in length
[ERROR] /home/r/repo/src/test/java/com/amihaiemil/docker/RtContainerTestCase.java:[505,9] constructor RtContainer in class com.amihaiemil.docker.RtContainer cannot be applied to given types;
[ERROR] required: javax.json.JsonObject,org.apache.http.client.HttpClient,java.net.URI
[ERROR] found: com.amihaiemil.docker.mock.AssertRequest,java.net.URI
[ERROR] reason: actual and formal argument lists differ in length
[ERROR] /home/r/repo/src/test/java/com/amihaiemil/docker/RtContainerTestCase.java:[521,9] constructor RtContainer in class com.amihaiemil.docker.RtContainer cannot be applied to given types;
[ERROR] required: javax.json.JsonObject,org.apache.http.client.HttpClient,java.net.URI
[ERROR] found: com.amihaiemil.docker.mock.AssertRequest,java.net.URI
[ERROR] reason: actual and formal argument lists differ in length
[ERROR] /home/r/repo/src/test/java/com/amihaiemil/docker/RtContainerTestCase.java:[537,9] constructor RtContainer in class com.amihaiemil.docker.RtContainer cannot be applied to given types;
[ERROR] required: javax.json.JsonObject,org.apache.http.client.HttpClient,java.net.URI
[ERROR] found: com.amihaiemil.docker.mock.AssertRequest,java.net.URI
[ERROR] reason: actual and formal argument lists differ in length
[ERROR] /home/r/repo/src/test/java/com/amihaiemil/docker/RtContainerTestCase.java:[553,9] constructor RtContainer in class com.amihaiemil.docker.RtContainer cannot be applied to given types;
[ERROR] required: javax.json.JsonObject,org.apache.http.client.HttpClient,java.net.URI
[ERROR] found: com.amihaiemil.docker.mock.AssertRequest,java.net.URI
[ERROR] reason: actual and formal argument lists differ in length
[ERROR] -> [Help 1]
[ERROR] 
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
container c58a0e3bc4088ed36dd54ac6e83f5bb019fc4e31ba02d21f0a796f95d7d29119 is dead
Wed May 23 20:59:04 CEST 2018

@llorllale
Copy link
Contributor

@amihaiemil looks like you need to update your branch

@amihaiemil amihaiemil merged commit 64341f4 into master May 24, 2018
@amihaiemil amihaiemil deleted the 117 branch May 24, 2018 16:38
@0crat
Copy link
Collaborator

0crat commented May 24, 2018

Order was finished: +15 point(s) just awarded to @llorllale/z

@0crat
Copy link
Collaborator

0crat commented May 24, 2018

The job #118 is now out of scope

@0crat
Copy link
Collaborator

0crat commented May 24, 2018

Payment to ARC for a closed pull request, as in §28: +10 point(s) just awarded to @amihaiemil/z

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants