Updates on handling recorders #770

dericed · 2023-11-05T18:48:28Z

No description provided.

dericed · 2023-11-05T19:01:56Z

This mixes a few updates, but generally removed bmdtools as an option (soon we can avoid triple-piped recording scenarios), and it swaps most of the use avfctl to dvrescue, and responds to a few feature requests.

libbyhopfauf

This seems to be working on my computers! I ended up having to go into recovery mode and resetting the permissions again (using the troubleshooting instructions here.) Now both devices show up on my computer via avfctl -list_devices and the vrecord GUI. Capture and packaging to MKV once capture is ended are working properly on my computers with this version.

libbyshopfauf@MacBook-Pro-55 ~ % avfctl -list_devices
2023-11-06 10:30:00.622 avfctl[1220:12548] Devices:
2023-11-06 10:30:00.623 avfctl[1220:12548] [0 - 0x8004601025e3c58] DV-VCR (Sony DSR-25)
2023-11-06 10:30:00.623 avfctl[1220:12548] [1 - 0x8004602010e007c] DSR-1500A (Sony DSR-1500A)

Computers tested:

Macbook Pro 2019 running Ventura 13.5.1
Macbook Pro 2021 running Ventura 13.5.1

Prior to resetting the permissions in recovery mode, I tried all of the other steps listed below (just in case it is helpful at all):

In the vrecord GUI, I tried rescanning, refreshing vrecord and restarting my computer multiple times. If I selected "deck control"" in the GUI and click "repack", I get a message that the deck is stopped (similar to the example in vrecord cannot see DV device #769):

I tried uninstalling and reinstalling the Blackmagic drivers (including having to reset the permissions again.)
Regarding my computers reading FireWire devices in general: if I ran avfctl -list_devices, I kept getting "No devices found." But if I ran ioreg -l, both DV devices connected are listed:

IOFireWireDevice@8004602010e007c  <clas$
    | |   |       |                   | {
    | |   |       |                   |   "FireWire Speed" = 0
    | |   |       |                   |   "FireWire Self IDs" = <816c08c0>
    | |   |       |                   |   "Vendor_ID" = 524358
    | |   |       |                   |   "FireWire Product Name" = "DSR-1500A"
    | |   |       |                   |   "FireWire Vendor Name" = "Sony"
    | |   |       |                   |   "FireWire Node ID" = 65473
    | |   |       |                   |   "FireWire Device ROM" = {"Offset 0"=<$
    | |   |       |                   |   "IOCFPlugInTypes" = {"CDCFCA94-F197-1$
    | |   |       |                   |   "GUID" = 576537726724997244
    | |   |       |                   |   "IOUserClientClass" = "IOFireWireUser$
    | |   |       |                   |   "Model_ID" = 3670189
	
	
    IOFireWireDevice@8004601025e3c58  <clas$
       | |   |           |               | {
       | |   |           |               |   "FireWire Speed" = 0
       | |   |           |               |   "FireWire Self IDs" = <816c08c2>
       | |   |           |               |   "Vendor_ID" = 524358
       | |   |           |               |   "FireWire Product Name" = "DSR-25"
       | |   |           |               |   "FireWire Vendor Name" = "Sony"
       | |   |           |               |   "FireWire Node ID" = 65535
       | |   |           |               |   "FireWire Device ROM" = {"Offset 0"=<$
       | |   |           |               |   "IOCFPlugInTypes" = {"CDCFCA94-F197-1$
       | |   |           |               |   "GUID" = 576537722452065368
       | |   |           |               |   "IOUserClientClass" = "IOFireWireUser$
       | |   |           |               |   "Model_ID" = 2097167

tomackroyd · 2023-11-08T04:52:10Z

Looking forward to trialling this. ~~@libbyhopfauf where are the troubleshooting instructions you mentioned?~~
edit:found

privatezero

Noticed a couple of gremlins!

privatezero · 2023-11-27T21:01:22Z

vrecord

@@ -2007,6 +2014,7 @@ _review_all_options(){
    fi
    _review_option -n -d "digital" "WAVEFORM_SCALE_CHOICE" "${WAVEFORM_SCALE_OPTIONS[@]}"
    _review_option -n -d "Broadcast Range" "SIGNAL_VIEW_CHOICE" "${SIGNAL_OPTIONS[@]}"
+    _review_option -n -d "As is" "SIGNAL_INT_CHOICE" "${INT_OPTIONS[@]}"


This line breaks things for me as _review_option will error by saying "As is" is not a valid option and exit. Does this work on your end?

changing "As is" to "auto" fixes this on my end - this settings for this option do not, however, persist currently and are not apparently stored in the config file - was this intentional?

I switched to 'auto'

privatezero · 2023-11-27T21:13:23Z

vrecord

+_get_dvrescue_inputs(){
+    # set dvrescue input options
+    unset DVRESCUE_DEVICES
+    while read dvrescue_device ; do


I think this needs to be moved into an else clause so it doesn't run if the system is Linux (at least until I have time to make changes to the code to switch Linux side over to dvrescue as well. As written this displays the device name detected via dvrescue in the options (yay! that's ultimately a good thing) but is misleading to users until dvrescue is integrated as currently linux vrecord can only capture from the default DV device

changing order to something like the following seems to work on linux for now:

_get_dvrescue_inputs(){ # set dvrescue input options if [[ "${OS_TYPE}" = "linux" ]] ; then DVRESCUE_DEVICES+=('Default DV Device') else unset DVRESCUE_DEVICES while read dvrescue_device ; do DVRESCUE_DEVICES+=("${dvrescue_device}") done < <(dvrescue -list_devices | grep "\[DV\]") if [[ "${#DVRESCUE_DEVICES[@]}" = 1 ]] ; then # default to first input if only one DVRESCUE_INPUT_CHOICE="${DVRESCUE_DEVICES[0]}" fi fi }

The latest update does a lot more with getting linux to grab the device id and use it. Can you retest.

privatezero · 2024-01-12T23:14:08Z

vrecord

-        if [[ -z "${ALT_INPUT}" ]] && [[ "${DECKLINK_UTILITY_CHOICE}" == "ffmpeg" ]] ; then
-            _review_option "TIMECODE_CHOICE" "${TIMECODE_OPTIONS[@]}"
-        fi
+        _review_option "TIMECODE_CHOICE" "${TIMECODE_OPTIONS[@]}"


this seems to break using most files for test inputs - suggest something like

if [[ -z "${ALT_INPUT}" ]] ; then _review_option "TIMECODE_CHOICE" "${TIMECODE_OPTIONS[@]}" fi

dericed · 2024-02-05T17:07:14Z

This is ready for a new review. Now avfctl is mostly gone and now dvrescue capture and playthrough is all done with just dvrescue and ffplay (or mpv) and not ffmpeg.

dericed · 2024-02-27T14:22:37Z

ping to @privatezero as mipops/dvrescue#827 (comment) relates to this.

privatezero · 2024-02-27T21:00:42Z

@dericed I've updated my issue there with results of another test

privatezero · 2024-03-08T00:31:48Z

@dericed I've made a modified version of this branch here: https://github.com/amiaopensource/vrecord/tree/updates-on-handling-recorders-linux

This branch adds a setting for allowing user to select capture tool for dv - this would be dvrescue on macs and dvrescue or ffmpeg via iec61883 device on Linux. Any thoughts? Having a bit of choice/redundancy on the Linux side is a positive I think!

for most things fixes #759 by adding id to dv inputs

just the repack one remains at the moment

simplify then add lightness

ablwr · 2024-04-26T22:35:12Z

You did it

…

On Fri, Apr 26, 2024, 6:04 PM Andrew Weaver ***@***.***> wrote: ***@***.**** approved this pull request. — Reply to this email directly, view it on GitHub <#770 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAY4ATHMT4PTTM4AQPHXJCDY7LFONAVCNFSM6AAAAAA66QUEIKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDAMRVHEZTAOJWGE> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

dericed force-pushed the updates-on-handling-recorders branch from c5b9d46 to 9f74228 Compare November 5, 2023 19:00

dericed mentioned this pull request Nov 5, 2023

vrecord cannot see DV device #769

Open

libbyhopfauf approved these changes Nov 6, 2023

View reviewed changes

tomackroyd mentioned this pull request Nov 16, 2023

2023-08-13 dvcapture not capturing mipops/dvrescue#724

Open

privatezero requested changes Nov 27, 2023

View reviewed changes

privatezero mentioned this pull request Dec 20, 2023

vrecord pipe error with DVCPRO ERR=141 #766

Open

dericed mentioned this pull request Jan 12, 2024

Can't install bmdtools from brew amiaopensource/homebrew-amiaos#374

Closed

privatezero reviewed Jan 12, 2024

View reviewed changes

dericed force-pushed the updates-on-handling-recorders branch from 254524e to 012415c Compare February 5, 2024 16:03

dericed force-pushed the updates-on-handling-recorders branch from f515bc5 to a491fff Compare February 5, 2024 20:53

dericed and others added 8 commits April 26, 2024 15:31

swap from avfctl to dvrescue

41efb84

for most things fixes #759 by adding id to dv inputs

renaming variables and functions, avfctl -> dvrescue

4c7e4ca

just the repack one remains at the moment

use less ffmpeg for dv capture

0d801b9

outdent after previous commit

3ba580f

remove FF_RECORD_COMMAND and 3-step vrecord captures

7bb9e33

remove unneeded addition

0423461

add dv capture choice - dvrescue/ffmpeg

1317b6d

simplify then add lightness

indent after previous commit

56bf3ae

dericed force-pushed the updates-on-handling-recorders branch from 3783304 to 56bf3ae Compare April 26, 2024 19:48

tweak for gtk list

b09dd62

privatezero approved these changes Apr 26, 2024

View reviewed changes

dericed merged commit 6696f08 into main Apr 29, 2024

dericed deleted the updates-on-handling-recorders branch April 29, 2024 13:34

dericed mentioned this pull request Apr 29, 2024

Allow different output from avfctl -list_devices #757

Closed

Updates on handling recorders #770

Updates on handling recorders #770

Uh oh!

Conversation

dericed commented Nov 5, 2023

Uh oh!

dericed commented Nov 5, 2023

Uh oh!

libbyhopfauf left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tomackroyd commented Nov 8, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

privatezero left a comment

Choose a reason for hiding this comment

Uh oh!

privatezero Nov 27, 2023

Choose a reason for hiding this comment

Uh oh!

privatezero Jan 12, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dericed Feb 5, 2024

Choose a reason for hiding this comment

Uh oh!

privatezero Nov 27, 2023

Choose a reason for hiding this comment

Uh oh!

privatezero Jan 12, 2024

Choose a reason for hiding this comment

Uh oh!

dericed Feb 5, 2024

Choose a reason for hiding this comment

Uh oh!

privatezero Jan 12, 2024

Choose a reason for hiding this comment

Uh oh!

dericed Feb 5, 2024

Choose a reason for hiding this comment

Uh oh!

dericed commented Feb 5, 2024

Uh oh!

dericed commented Feb 27, 2024

Uh oh!

privatezero commented Feb 27, 2024

Uh oh!

privatezero commented Mar 8, 2024

Uh oh!

ablwr commented Apr 26, 2024 via email

Uh oh!

Uh oh!

libbyhopfauf left a comment •

edited

Loading

tomackroyd commented Nov 8, 2023 •

edited

Loading

privatezero Jan 12, 2024 •

edited

Loading