Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Silence trim #367

Merged
merged 6 commits into from
Feb 4, 2019
Merged

Silence trim #367

merged 6 commits into from
Feb 4, 2019

Conversation

privatezero
Copy link
Member

Adds recipes for trimming silence from front/end of audio file

Copy link
Member

@kfrn kfrn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! I haven't tested the actual recipes, but everything looks good to me.

index.html Outdated
<h3>Remove silent portion at the beginning of an audio file</h3>
<p><code>ffmpeg -i <em>input_file</em> -af silenceremove=start_threshold=-57dB:start_duration=1:start_periods=1 -c:a <em>your_codec_choice</em> -ar <em>your_sample_rate_choice</em> <em>output_file</em></code></p>
<p>This command will automatically remove silence at the beginning of an audio file. The threshold for what qualifies as silence can be changed - this example uses anything under -57 dB, which is a decent level for accounting for analogue hiss.</p>
<p>Note: Since this is applying a filter, you can not use codec copy for your output. If you do not specify an output sample rate and codec this command will use <a href='#codec-defaults'>the defaults for your output format</a>. Take care that you are getting your intended results!</p>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick, but it might be clearer to say something like "Since this recipe involves a filter, the audio stream will be re-encoded". Your call though

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dig

Copy link
Member

@retokromer retokromer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’m not English speaker, yet LGTM.

@privatezero
Copy link
Member Author

Hmm, one other question for the group - it isn't strictly necessary for the user to specify -ar as FFmpeg should pull that from the source, even with the transcode. I put that in as I can see one of the big use cases for this is creating lower sample rate mezzanine files, but maybe it would be cleaner without??

@retokromer
Copy link
Member

Good point! I guess it would be clearer without it in the main recipe, but I suggest to add this information as a comment.

@privatezero
Copy link
Member Author

Aight! removed -ar from recipe. Hopefully changed wording makes sense

Copy link
Member

@retokromer retokromer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@privatezero privatezero merged commit 47575a5 into gh-pages Feb 4, 2019
@privatezero privatezero deleted the silence-trim branch February 4, 2019 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants