Dockerise root #40
Merged
Dockerise root #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements docker containers and workflow files for pushing them to the Github container registry at amfoss/packages
One notable change is the removal/modification of the
BIND_PORTenvironment variable, this was changed to only supply the port number. This was done to ensure compatibility with the master compose file at infra-core and also because bind addresses are irrelevant inside docker containers.Note that we are moving to a twin branch workflow where the
masterbranch will be used exclusively for releases and stable code, all fixes and features need to developed on separate branches and when its time for release they can be merged withmaster, this will kick off the deployment process.