Skip to content

feat(api): add API server config block #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mawandm merged 2 commits into from
Apr 24, 2024
Merged

feat(api): add API server config block #44

mawandm merged 2 commits into from
Apr 24, 2024

Conversation

@mawandm
Copy link
Contributor

@mawandm mawandm commented Apr 23, 2024 •
edited
Loading

We introduce an explicit server config block and environment variables for;

  1. API server port NESIS_API_SERVER_PORT
  2. API server listen address NESIS_API_SERVER_ADDRESS

This is to allow easier configuration during deployment via environment variables of config yaml.

Part of #25

@mawandm mawandm enabled auto-merge (squash) April 23, 2024 23:21
@mawandm mawandm requested a review from akizito April 23, 2024 23:21
@mawandm mawandm merged commit ac648fd into main Apr 24, 2024
@mawandm mawandm deleted the 25-add-api-server-config branch April 24, 2024 04:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@akizito akizito akizito approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mawandm @akizito