Skip to content

Consider inlcuding the entity generation in ComponentEvent #720

Open

Description

@Imberflur

Description

Including the entity generation instead of just the index within the component event used by FlaggedStorage.

Motivation

When an entity is deleted removal events are generated for its components in FlaggedStorages. If another entity is created at the same index there is no way to tell if the removed components are from the old entity or the new one. When using this for network syncing the means we end up sending useless component removed events (since we can't be sure they don't apply to the new entity).

Drawbacks

This would be a breaking change and would increase the size of ComponentEvent

Unresolved questions


I would be happy to implement this if approved.

Activity

  1. Dollab commented on Jan 15, 2021

    @Dollab

    This would be very useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions