Skip to content

MarkerAllocator::maintain is never called #713

Open

Description

@wez

Description

Apologies if I've overlooked something, but AFAICT, nothing ever calls this trait method.
Is this something that I need to setup for myself?
I've been using https://specs.amethyst.rs/docs/tutorials/13_saveload.html as a reference to
use with my own allocator impl, and that doesn't give guidance on how maintain is called.

Meta

Rust version: rustc 1.48.0 (7eac88abb 2020-11-16)
Specs version / commit: 0.16 but I also looked through 1fd81cd and didn't find any callers
Operating system: N/A, but I'm on Linux.

Reproduction

$ cd specs
$ grep -r maintain .
<none of the results show maintain being called with any arguments>

Expected behavior

Either something should call maintain inside specs, or the documentation should explain how best to perform that maintenance!

Activity

  1. LoganDark commented on Feb 21, 2021

    @LoganDark

    It looks like maintain is a method used to commit atomic operations to your backing storage. See this section for a bit of context.

    Shouldn't it be called by World::maintain?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions