Add support iterating across all entities #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- rename enumerate_entities to iter_entity_locations - add iter_entities, returning an iterator of just entities
Veykril
reviewed
Feb 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is implemented by iterating component storage to find live entities. I'm using this for comparing two worlds and detecting what has been added between the two worlds.
The function enumerate_entities already existed. I considered renaming it to enumerate_entity_locations but that seemed a bit long. Also, I see more usages of iter_* than enumerate_* in standard library, so maybe it's a tiny bit more idiomatic, maybe?
I don't have a strong opinion about the naming though. Happy to change it to whatever you prefer!