Skip to content
This repository has been archived by the owner on May 3, 2024. It is now read-only.

Fastify migration #852

Merged

Conversation

giulianok
Copy link
Member

@giulianok giulianok commented Nov 8, 2022

Description

This PR is a simpler version of #807. Multiple small PRs are targeting feature/fastify-migration for easy review. Once all PRs are merged into feature/fastify-migration, this PR will look very similar to #807 and all tests will pass

Motivation and Context

How Has This Been Tested?

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (adding or updating documentation)
  • Dependency update
  • Security update

Checklist:

  • My change requires a change to the documentation and I have updated the documentation accordingly.
  • These changes should be applied to a maintenance branch.
  • This change requires cross browser checks.
  • Performance tests should be ran against the server prior to merging.
  • This change impacts caching for client browsers.
  • This change impacts HTTP headers.
  • This change adds additional environment variable requirements for One App users.
  • I have added the Apache 2.0 license header to any new files created.

What is the Impact to Developers Using One App?

@github-actions
Copy link
Contributor

github-actions bot commented Nov 8, 2022

Size Change: +8.13 kB (+1%)

Total Size: 689 kB

Filename Size Change
./build/app/app.js 173 kB +7.5 kB (+5%) 🔍
./build/app/app~vendors.js 387 kB +512 B (0%)
./build/app/service-worker-client.js 7.26 kB -3 B (0%)
./build/app/vendors.js 114 kB +115 B (0%)
ℹ️ View Unchanged
Filename Size
./build/app/runtime.js 7.07 kB

compressed-size-action

giulianok and others added 8 commits November 28, 2022 10:48
refactor: utilities to meet fastify requirements
refactor: migrated ssrServer to fastify
refactor: react to html plugin
refactor: pwa required changes to work with fastify
* refactor: converted middlewares into plugins
fix: fastify tests
@giulianok giulianok changed the title [WIP] Fastify migration Fastify migration Dec 1, 2022
@giulianok giulianok marked this pull request as ready for review December 1, 2022 22:12
@giulianok giulianok requested review from a team as code owners December 1, 2022 22:12
@giulianok giulianok changed the base branch from main to feature/express-fastify-migratoin December 5, 2022 12:01
@giulianok giulianok merged commit 31ce34e into feature/express-fastify-migratoin Dec 5, 2022
@giulianok giulianok deleted the feature/fastify-migration branch December 5, 2022 12:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant