This repository has been archived by the owner on May 3, 2024. It is now read-only.
Chore/release process improvements #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Jonny Adshead <JAdshead@users.noreply.github.com>
Co-Authored-By: Jonny Adshead <JAdshead@users.noreply.github.com>
Co-Authored-By: Jonny Adshead <JAdshead@users.noreply.github.com>
Co-Authored-By: Jonny Adshead <JAdshead@users.noreply.github.com>
Co-Authored-By: Jonny Adshead <JAdshead@users.noreply.github.com>
Co-Authored-By: Mike Tobia <Francois-Esquire@users.noreply.github.com>
Co-Authored-By: Mike Tobia <Francois-Esquire@users.noreply.github.com>
mtomcal
previously approved these changes
May 5, 2020
infoxicator
previously approved these changes
May 6, 2020
Co-authored-by: Mike Tobia <Francois-Esquire@users.noreply.github.com>
…om/americanexpress/one-app into chore/release-process-improvements
Thank you 😄 |
Francois-Esquire
previously approved these changes
May 6, 2020
Co-authored-by: Mike Tobia <Francois-Esquire@users.noreply.github.com>
JAdshead
reviewed
May 6, 2020
RELEASE.md
Outdated
| 2. After the the generated tag is pushed to the branch this will trigger the docker build and publish the statics and push the images to Docker Hub. The development and production images would be accessible in docker [https://hub.docker.com/u/oneamex](https://hub.docker.com/u/oneamex) | ||
| 3. The statics assets will be published and added to a tag that has been released via the [release static assets action](.github/workflows/docker_release.yml) |
There was a problem hiding this comment.
Suggested change
| 3. The statics assets will be published and added to a tag that has been released via the [release static assets action](.github/workflows/docker_release.yml) | |
| 3. The statics assets will be published and added to the tag created via the [release static assets action](.github/workflows/docker_release.yml) as part of the previous step. |
RELEASE.md
Outdated
| 2. After the the generated tag is pushed to the branch this will trigger the docker build and publish the statics and push the images to Docker Hub. The development and production images would be accessible in docker [https://hub.docker.com/u/oneamex](https://hub.docker.com/u/oneamex) | ||
| 3. The statics assets will be published and added to a tag that has been released via the [release static assets action](.github/workflows/docker_release.yml) | ||
| 4. We are currently using [https://github.com/release-drafter/release-drafter](https://github.com/release-drafter/release-drafter) to generate release notes. This is a github action that generates draft releases note that can be added to the released tag. Please add the labels specified within [release-drafter](.github/release-drafter.yml) to categorize different pull requests to ensure that any changes are categorized correctly. You can also use the changelog generated for this content. |
There was a problem hiding this comment.
does release-drafter have to use labels or can it use commits ? can we auto label based of the commit.
If we take the changes add as part of the changelog do we even need release drafter ?
There was a problem hiding this comment.
We have some work to address this in a separate PR
RELEASE.md
Outdated
| 2. After the the generated tag is pushed to the branch this will trigger the docker build and publish the statics and push the images to Docker Hub. The development and production images would be accessible in docker [https://hub.docker.com/u/oneamex](https://hub.docker.com/u/oneamex) | ||
| 3. The statics assets will be published and added to a tag that has been released via the [release static assets action](.github/workflows/docker_release.yml) | ||
| 4. We are currently using [https://github.com/release-drafter/release-drafter](https://github.com/release-drafter/release-drafter) to generate release notes. This is a github action that generates draft releases note that can be added to the released tag. Please add the labels specified within [release-drafter](.github/release-drafter.yml) to categorize different pull requests to ensure that any changes are categorized correctly. You can also use the changelog generated for this content. | ||
| 5. Update the draft release notes with any changes required and tie it to the released tag. |
There was a problem hiding this comment.
what do you mean by "tie it" ?
Suggested change
| 5. Update the draft release notes with any changes required and tie it to the released tag. | |
| 5. Update the draft release notes with any changes required and edit the released tag to add them there. |
RELEASE.md
Outdated
|
|
||
| ### Docker Images | ||
| ``` | ||
| [Paste changelog entries here] |
There was a problem hiding this comment.
is all this white space necessary ?
There was a problem hiding this comment.
Remove this, i had missed this earlier
Francois-Esquire
previously approved these changes
May 6, 2020
infoxicator
previously approved these changes
May 6, 2020
JAdshead
approved these changes
May 6, 2020
JamesSingleton
approved these changes
May 6, 2020
Francois-Esquire
approved these changes
May 6, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
standard versionhas an open issue Why are there duplicate records on different versions conventional-changelog/standard-version#509, which generates empty changelogs.Motivation and Context
Improve the One App release process
How Has This Been Tested?
with changelog changes --> One App Prepare Release nellyk/one-app#92
docker release run https://github.com/nellyk/one-app/actions/runs/95351257
Types of Changes
Checklist:
What is the Impact to Developers Using One App?
No impact, improves the release process for the One App