Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: configurations not loading from package.json #487

Merged
merged 2 commits into from
Oct 7, 2023

Conversation

friendlymahi
Copy link

  • Fixes : Package gets created in target folder instead of custom path provided

Fixes #486

Proposed Changes

  • Call the method getConfigsFromPackage instead of passing the identifier

Screenshots and Logs

Before

Last line from log : AEM package has been created and can be found in the current user's Maven package repository or in ./target

After

Last line from log : AEM package has been created and can be found in the current user's Maven package repository or in ./build-aem/package

Background context

...fill in details explaining why this is important or this approach should be used to solve the issue...

Where should the reviewer start / What requires special attention?

...specific files or actions...

How should this be manually tested?

  1. Create a new AEM project using react as frontend module type
  2. Include aem-packager in package.json dev dependencies and then use entries below for aem-packager section for ui.frontend module
  3. Update build script as react-scripts build && clientlib && aem-packager
  4. Execute the command npm i followed by npm build
  5. You shall see that package is created in target folder before this PR and will be the custom path mentioned in sample config section share in step2

Questions:

  • Does this add new dependencies (node, maven, ant, etc) that must be installed?
    -No
  • Does this change the commands required to run this project?
    -No
  • Are any environmental dependencies or operational support steps (sql commands, config changes, etc) required?
    -No
  • Are there any relevant issues besides this one?
    • No

- Package gets created in target folder instead of custom path provided

Closes amclin#486
@friendlymahi
Copy link
Author

@amclin - Requesting you to review this issue and PR, and if everything looks good, please merge the PR. Thanks !

@friendlymahi
Copy link
Author

@amclin - hope you are doing well. can you please review this PR as I would like to use this package for our teams where aem or Java development is not required. If not feasible please let me know so I can copy over the code to our internal module and remove it once you merge the PR. Thanks

@amclin amclin changed the title fix: config merge fix fix: configurations not loading from package.json Oct 7, 2023
@amclin amclin merged commit 00b5501 into amclin:master Oct 7, 2023
7 checks passed
@amclin
Copy link
Owner

amclin commented Oct 7, 2023

Thanks for the fix @friendlymahi !

@amclin
Copy link
Owner

amclin commented Oct 7, 2023

🎉 This PR is included in version 3.1.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

@amclin amclin added the released label Oct 7, 2023
@friendlymahi
Copy link
Author

Thanks a lot for accepting the fix. Can you please review the other pr for new maven plug in version as the old one is or working as expected and not supported by Adobe any more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When using entries in package.json options is not recognized properly
2 participants