fix: configurations not loading from package.json #487
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #486
Proposed Changes
getConfigsFromPackage
instead of passing the identifierScreenshots and Logs
Before
Last line from log : AEM package has been created and can be found in the current user's Maven package repository or in ./target
After
Last line from log : AEM package has been created and can be found in the current user's Maven package repository or in ./build-aem/package
Background context
...fill in details explaining why this is important or this approach should be used to solve the issue...
Where should the reviewer start / What requires special attention?
...specific files or actions...
How should this be manually tested?
aem-packager
in package.json dev dependencies and then use entries below foraem-packager
section for ui.frontend modulereact-scripts build && clientlib && aem-packager
npm i
followed bynpm build
Questions:
-No
-No
-No