Skip to content

Fix PHP 7.4 deprecation warnings #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Fix PHP 7.4 deprecation warnings #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2f0cead
replace curly brace with square bracket
terdia Dec 17, 2020
5fc2be0
applied fix for get_magic_quotes_gpc deprecation
terdia Dec 17, 2020
3294631
fix trying to access array offset on value of type null issue
terdia Apr 23, 2021
2caf3e1
code style
terdia May 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/form/sfForm.class.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,11 +63,12 @@ class sfForm implements ArrayAccess, Iterator, Countable
*/
public function __construct($defaults = array(), $options = array(), $CSRFSecret = null)
{
$this->validatorSchema = new sfValidatorSchema();

Comment on lines +66 to +67
Copy link
Collaborator

@obukhov obukhov May 18, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a bit unclear from the description (why it is needed)

Copy link
Author

@terdia terdia May 18, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$this->validatorSchema was used in line 947 before it was initialized, this code $this->validatorSchema[self::$CSRFFieldName] tries to access a key in validatorSchema the usage is triggered by $this->setDefaults($defaults) which calls the function $this->isCSRFProtected() this resulted in an exception trying to access array offset on value of type null

Copy link
Author

@terdia terdia May 18, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2021-05-18 at 10 29 56

$this->setDefaults($defaults);
$this->options = $options;
$this->localCSRFSecret = $CSRFSecret;

$this->validatorSchema = new sfValidatorSchema();
$this->widgetSchema = new sfWidgetFormSchema();
$this->errorSchema = new sfValidatorErrorSchema($this->validatorSchema);

Expand Down
Loading