Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: ambient-code/agentready
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.26.0
Choose a base ref
...
head repository: ambient-code/agentready
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v1.27.0
Choose a head ref
  • 3 commits
  • 7 files changed
  • 4 contributors

Commits on Nov 23, 2025

  1. test: add comprehensive unit tests for data models (#110) 

    Add 70+ comprehensive unit tests for DiscoveredSkill, Fix models
(CommandFix, FileCreationFix, FileModificationFix, MultiStepFix),
Finding, and Remediation models to achieve 90% coverage target.

Tests include:
- Validation testing using pytest.mark.parametrize
- Constructor testing with valid/invalid inputs
- Factory method testing (Finding.not_applicable, skipped, error)
- Serialization testing (to_dict methods)
- Apply/preview testing for Fix models
- Edge case testing (empty values, out-of-range scores)

Target coverage improvement: 35-70% → 90% for models

Co-authored-by: claude[bot] <41898282+claude[bot]@users.noreply.github.com>
Co-authored-by: Jeremy Eder <jeremyeder@users.noreply.github.com>
    @jeremyeder @github-actions
    3 people authored Nov 23, 2025
    Configuration menu
    Copy the full SHA
    82ab053 View commit details
    Browse the repository at this point in the history

  2. feat: Add comprehensive unit tests for utility modules (privacy.py an… 

    …d subprocess_utils.py) (#111)

- Add 64 test cases for privacy.py covering all 5 functions
  - Path sanitization (home/username redaction, relative paths)
  - Command argument sanitization (flags, paths, API keys)
  - Error message sanitization (paths, emails, API keys, truncation)
  - Commit hash shortening (various lengths, edge cases)
  - Metadata dictionary sanitization (mixed values, type preservation)

- Add 37 test cases for subprocess_utils.py covering all 3 functions
  - Repository path validation (git repos, forbidden paths, symlinks)
  - Subprocess error sanitization (paths, usernames, truncation)
  - Safe subprocess execution (timeouts, output limits, security checks)
  - Security constants validation

- Test coverage improvements:
  - Parametrized tests for multiple scenarios
  - Mocked external dependencies (getpass, Path.home(), subprocess.run)
  - Error path testing (exceptions, timeouts, invalid inputs)
  - Edge cases (empty strings, None values, long messages)
  - Security validation (forbidden paths, API key redaction, size limits)

Target: Achieve 90%+ coverage for both modules (Phase 2)

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-authored-by: claude[bot] <41898282+claude[bot]@users.noreply.github.com>
Co-authored-by: Jeremy Eder <jeremyeder@users.noreply.github.com>
    @jeremyeder @github-actions
    3 people authored Nov 23, 2025
    Configuration menu
    Copy the full SHA
    9d3dece View commit details
    Browse the repository at this point in the history

  3. chore(release): 1.27.0 [skip ci] 

    # [1.27.0](v1.26.0...v1.27.0) (2025-11-23)

### Features

* Add comprehensive unit tests for utility modules (privacy.py and subprocess_utils.py) ([#111](#111)) ([9d3dece](9d3dece))
    @semantic-release-bot
    semantic-release-bot committed Nov 23, 2025
    Configuration menu
    Copy the full SHA
    924c2ee View commit details
    Browse the repository at this point in the history
Loading