This repository was archived by the owner on Oct 13, 2025. It is now read-only.
Fixes infinite loop bugs in text parsing of lobs and strings. #160
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
popematt
approved these changes
Jun 18, 2025
nirosys
approved these changes
Jun 18, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
The following is a GitHub Actions workflow for a commit that includes only the new test added by this PR. The tests are hanging forever. https://github.com/amazon-ion/ion-dotnet/actions/runs/15742521485/job/44371188161
The changes to the source in this PR fix those potential infinite loops by throwing
UnexpectedEofExceptionwhenCharSeqEof(a constant with value-1) is encountered in the middle of a token that is expected to be complete. Before,TextConstants.TokenEof(a constant with value0) was checked, causing a loop when the stream produced-1to indicate it had reached its end.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.