[receiver/prometheus] Disable pkg.translator.prometheus.NormalizeName by default #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sky333999
force-pushed
the
merge-v77-fix-normalized-name
branch
3 times, most recently
from
0cc1bfd
to
f275a28
Compare
jefchien
previously approved these changes
Jun 3, 2023
…izeName by default (open-telemetry#20519)" This reverts commit 8b0fb2f
sky333999
force-pushed
the
merge-v77-fix-normalized-name
branch
from
f275a28
to
2bd9389
Compare
jefchien
approved these changes
Jun 5, 2023
adam-mateen
approved these changes
Jun 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: This is a follow up to #28 where an upstream change (open-telemetry#20518) enabled a feature to normalize metric names by default.
This causes a test failure on our end and in order to mitigate that and bring us back to a stable state, reverting this change to disable this feature by default.
Testing: Relying on build checks & tests.