allow multiple log group names/arns to be set in environmental variables for xray exporter #218
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This commit is to allow users to set multiple log group names or arns using environmental variable. We choose to use
&
to separate individual log group name or arn because&
is not allowed in log group names (https://docs.aws.amazon.com/AmazonCloudWatchLogs/latest/APIReference/API_CreateLogGroup.html) and&
implicitly means 'AND'.Link to tracking Issue:
N/A
Testing:
Unit tests.
Manual end 2 end test confirmed that we get 2 log groups in the raw trace with the change. Note the
cloudwatch_logs
field below:Documentation:
An example in the readme for xray exporter