Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[exporter/awsxray] Add aws sdk http error events to x-ray subsegment and strip prefix AWS.SDK. from aws remote service name #113

Merged
merged 4 commits into from
Oct 12, 2023
Merged

[exporter/awsxray] Add aws sdk http error events to x-ray subsegment and strip prefix AWS.SDK. from aws remote service name #113

merged 4 commits into from
Oct 12, 2023

Commits on Oct 11, 2023

  1. add aws sdk http error events to x-ray subsegment

    @pxaws @jknollmeyer
    pxaws authored and jknollmeyer committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    e148b0a View commit details
    Browse the repository at this point in the history

  2. Pull Request review changes for open-telemetry#27232 

    - Define "aws-api" as a const
- Rename some variables in cause.go to make the intended behavior a little more clear
- PR: open-telemetry#27232
    @jknollmeyer
    jknollmeyer committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    e746306 View commit details
    Browse the repository at this point in the history

  3. Change the time used for X-Ray exception events to unix epoch time 

    - timestamp.String() generates a string like "2023-10-10 01:58:24.675761 +0000 UTC", which is not a standardized format
- Under the hood, it is just calling AsTime().String() https://github.com/open-telemetry/opentelemetry-collector/blob/pdata/v0.66.0/pdata/pcommon/timestamp.go#L36
- Time.String() has the warning "The returned string is meant for debugging; for a stable serialized representation, use t.MarshalText, t.MarshalBinary, or t.Format with an explicit format string." https://pkg.go.dev/time#Time.String
    @jknollmeyer
    jknollmeyer committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    8beda9a View commit details
    Browse the repository at this point in the history

Commits on Oct 12, 2023

  1. Change the time used for X-Ray exception events to microsecond precision 

    - This matches X-Ray guidance for timestamps - "Microsecond reoslution is recommended when available" https://docs.aws.amazon.com/xray/latest/devguide/xray-api-segmentdocuments.html#api-segmentdocuments-fields
    @jknollmeyer
    jknollmeyer committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    5033415 View commit details
    Browse the repository at this point in the history