Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

infra: remove pydantic constraints #224

Merged
merged 2 commits into from
Feb 29, 2024
Merged

infra: remove pydantic constraints #224

merged 2 commits into from
Feb 29, 2024

Conversation

AbeCoull
Copy link
Contributor

@AbeCoull AbeCoull commented Feb 29, 2024

Issue #, if available:

Description of changes:
This relaxes the constraints for what Pydantic version is used. This imports the schemas package which already dictates that for Braket packages. If this relationship is decoupled, then would make sense to add back.

Testing done:
Ran unit tests and linters

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have checked that my tests are not configured for a specific region or account (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link

codecov bot commented Feb 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (2ec9fd6) to head (c47b12e).

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #224   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           48        48           
  Lines         3744      3744           
  Branches       910       910           
=========================================
  Hits          3744      3744           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AbeCoull AbeCoull changed the title infra: unpin pydantic infra: remove pydantic constraints Feb 29, 2024
@AbeCoull AbeCoull merged commit 7572917 into main Feb 29, 2024
33 checks passed
@AbeCoull AbeCoull deleted the pydantic branch February 29, 2024 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants