-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change: Make Braket.jl an optional dependency with package extension #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kshyatt-aws
force-pushed
the
ksh/nobraket
branch
from
August 8, 2024 19:10
609cdde
to
b90713b
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #36 +/- ##
==========================================
+ Coverage 96.87% 97.63% +0.76%
==========================================
Files 16 23 +7
Lines 2716 3174 +458
==========================================
+ Hits 2631 3099 +468
+ Misses 85 75 -10 ☔ View full report in Codecov by Sentry. |
rmshaffer
reviewed
Aug 8, 2024
kshyatt-aws
force-pushed
the
ksh/nobraket
branch
from
August 9, 2024 00:15
46efa3e
to
ba7753f
Compare
kshyatt-aws
force-pushed
the
ksh/nobraket
branch
from
August 9, 2024 15:12
9b58296
to
afd4d2b
Compare
rmshaffer
previously approved these changes
Aug 9, 2024
5 tasks
Just FYI we should not merge this until we have verified the notebooks will work with these changes |
kshyatt-aws
force-pushed
the
ksh/nobraket
branch
from
August 15, 2024 21:34
b1d25c4
to
12de4f1
Compare
5 tasks
rmshaffer
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes: Move basic gates, noises, and circuits into
BraketSimulator.jl
and add aBraket.jl
extension so we can strip out all the HTTP, JSON, etc. support. Also add support for non-integer exponents of gates.Testing done: Unit tests passed locally.
Merge Checklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
Tests
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.