Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change: Make Braket.jl an optional dependency with package extension #36

Merged
merged 9 commits into from
Aug 19, 2024

Conversation

kshyatt-aws
Copy link
Contributor

Issue #, if available:

Description of changes: Move basic gates, noises, and circuits into BraketSimulator.jl and add a Braket.jl extension so we can strip out all the HTTP, JSON, etc. support. Also add support for non-integer exponents of gates.

Testing done: Unit tests passed locally.

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have checked that my tests are not configured for a specific region or account (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@kshyatt-aws kshyatt-aws requested a review from a team as a code owner August 8, 2024 01:20
Copy link

codecov bot commented Aug 8, 2024

Codecov Report

Attention: Patch coverage is 96.56652% with 32 lines in your changes missing coverage. Please review.

Project coverage is 97.63%. Comparing base (83850ed) to head (75ae26a).
Report is 1 commits behind head on main.

Files Patch % Lines
...aketSimulatorPythonExt/BraketSimulatorPythonExt.jl 50.00% 5 Missing ⚠️
src/raw_schema.jl 86.84% 5 Missing ⚠️
src/observables.jl 94.87% 4 Missing ⚠️
...aketSimulatorBraketExt/BraketSimulatorBraketExt.jl 95.31% 3 Missing ⚠️
src/BraketSimulator.jl 97.76% 3 Missing ⚠️
src/noises.jl 93.87% 3 Missing ⚠️
src/builtin_functions.jl 66.66% 2 Missing ⚠️
src/circuit.jl 98.52% 2 Missing ⚠️
src/operators.jl 93.54% 2 Missing ⚠️
src/Quasar.jl 98.79% 1 Missing ⚠️
... and 2 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #36      +/-   ##
==========================================
+ Coverage   96.87%   97.63%   +0.76%     
==========================================
  Files          16       23       +7     
  Lines        2716     3174     +458     
==========================================
+ Hits         2631     3099     +468     
+ Misses         85       75      -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

rmshaffer
rmshaffer previously approved these changes Aug 9, 2024
@kshyatt-aws
Copy link
Contributor Author

Just FYI we should not merge this until we have verified the notebooks will work with these changes

@kshyatt-aws kshyatt-aws requested a review from rmshaffer August 17, 2024 20:15
@kshyatt-aws kshyatt-aws merged commit 89be354 into main Aug 19, 2024
12 of 14 checks passed
@kshyatt-aws kshyatt-aws deleted the ksh/nobraket branch August 19, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants