This repository was archived by the owner on Jul 7, 2020. It is now read-only.
fixes(#2196) #12
Merged
fixes(#2196) #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haverchuck
assigned
mlabieniec,
jordanranz,
manueliglesias,
powerful23 and
elorzafe and unassigned
mlabieniec,
jordanranz,
manueliglesias,
powerful23 and
elorzafe
haverchuck
requested review from
elorzafe,
jordanranz,
manueliglesias,
mlabieniec and
powerful23
elorzafe
reviewed
Dec 27, 2018
| "build": "node build/build.js" | ||
| }, | ||
| "dependencies": { | ||
| "@vue/cli-plugin-unit-jest": "^3.2.0", |
Contributor
Author
There was a problem hiding this comment.
That's what I thought, but for some reason the vue cli put this in dependencies (and I followed their lead). I could probably change it, I just wanted to get this fix out quickly since the issue was stale.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Fixes #2196
Description of changes:
Adds proper unit test tooling and updates sample test.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.