Add subtitle option for outline thickness #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll try it later. I seen that you add the new settings items which is great, but make sure that settings addition not covering the subtitle preview (on tv layout landscape 16;9) |
|
It seems to be fine for 16:9 for now. In the below screenshot I tested using the largest font settings I could find, and it's barely not touching it. So, I could see this being a problem if an 8th setting is added in the future... |
|
uh, nice. |
|
thx |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new subtitle style setting for "outline". The default "Thin Outline" setting reflects the current behavior. Thicker options use
-webkit-text-stroke-width.My main motivation for this is due do the current outline being far too thin for me personally. I typically watch on low brightness, so the thin outline on a bright background makes it hard to make out the text.
Feel free to close this PR or make suggestions if my approach is unwelcome.