Add browserify compatibility #643
Conversation
Not yet working.
Moves `@trust/crypto` and `text-encoding` into the package.json's dependencies, since it depends on them. Allows for importing SEA using browserify or node. Fixes amark#642
|
docs are great, will definitely snag that. For dependency, we'd need to add node-webcrypto-ossl also, but the community had moved these to devDependencies before (see the issue you opened). I'm also fine moving them back to dependencies... would just like to hear your thoughts on what the right balance between install difficulty vs. opt-in install use... either way, docs calling this out exactly addresses it. THANK YOU. ...will be back after Thanksgiving stuff. |
|
Fixes #642 |
|
@danfinlay @kumavis just got back from SD for Thanksgiving. Sick, but trying to catch up on stuff now. I'll pull this (and add I am curious your thoughts about hardcoding these optional dependencies, especially after the NPM debacle that happened the other day - are you still of the same mindset after that? Having SEA be its own module is very interesting to me - I'd want other projects to already use it (maybe this MetaMask integration will pave the way???) first and then donate it to some independent /foundation to house it. I think it'll be very important for future dApps, integrations, plugins, etc. to standardize around. |
|
What NPM debacle are you refering to ? None of the problems NPM has from time to time change the need for packages that depend on something else to require that code ! |
|
Pulling! @mitra42 trying to be clear: these are shims, they are not dependencies. Are they needed in certain contexts, yes. Does that make it obvious they should add 10X the overhead to installing GUN? I don't think so. Also, in a local commit I have added to SEA an option to have it throw errors, per your request (note: It won't be default, as it causes NodeJS to crash unless you try/catch it). Hopefully this'll come out in the next release (haven't had much time to code lately though, not sure when it'll be going out). Hope this will make you happy. :) |
|
Okay this got bumped up again, should go out in next NPM release ... probably after back from trip. |
Fixed dependencies and added documentation for easier inclusion in a browserify or webpack project.