Reliably check file.js options #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The FileJS module can be passed options in two ways, and this commit ensures they're treated in the right way. Previously, options passed as .put or .get parameters would be favored over those used on the chain, even if `file` wasn't specified. Now, the module will only use the method options if `file` is mentioned, falling back to the chain options. This was a mistake on my part with the first PR (#268), I failed to notice notice that edge case.
If you're reading this commit history, please avert your eyes. 3 commits to fix this admittedly simple problem is more than my pride can handle. The `gun.Back()` function was only searching for `opt`, not `opt.file`. It would stop at the first mention of `opt` even if it didn't have settings for `file`. Now it won't.
|
I'm sure this is good... go ahead and merge yourself, please. :) |
|
You got it, Mark. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The FileJS module can be passed options in two ways, and this commit
ensures they're treated in the right way.
Previously, options passed as .put or .get parameters would be favored
over those used on the chain, even if
filewasn't specified. Now, themodule will only use the method options if
fileis mentioned, fallingback to the chain options.
This was a mistake on my part with the first PR (#268), I failed to notice that edge case.