Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.off for .on, .map, and .path #252

Merged
merged 1 commit into from
Oct 23, 2016
Merged

.off for .on, .map, and .path #252

merged 1 commit into from
Oct 23, 2016

Conversation

alancnet
Copy link
Collaborator

Gun needs a way to unsubscribe from changes. On provides an off function by adding it to the options passed in, but that is not available to .on, .map, and .path This commit will provide .off on gun itself.

Resource management is critical for single page applications, and long-running server-side applications.

I hope I covered all relevant bases. I didn't expect to need to cover .path, but it was necessary to unsubscribe from a .map.

[Resubmitting due to random failure in Travis]

@amark amark merged commit c006690 into amark:master Oct 23, 2016
@amark
Copy link
Owner

amark commented Oct 23, 2016

My phone just deleted everything I typed :(

@amark
Copy link
Owner

amark commented Oct 23, 2016

Sorry about Travis, there are some perf tests that are nondeterministic and randomly fail on older version, need to get that fixed I apologize.

How on earth did you figure this out? You musr be sone sort of super genius! Especially on the fragile and ugly 0.3? I can't wait for you to see 0.5 codebase because it is so much better. Thank you for this contribution!

I am very impressed! You set an incredible example of contributing to Open Source. We should get you commit access! (Idk how to on phone, so next time) It is an honor to have you in the community, any community would be proud of somebody like you! The world needs more of that, so thank you!

@alancnet
Copy link
Collaborator Author

Thanks dude! I'm flattered. I just submitted the 0.5 PR's. The HEAD unit tests seem to be in bad shape though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants