Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

package.json: adopt a common format #16

Closed
wants to merge 1 commit into from
Closed

package.json: adopt a common format #16

wants to merge 1 commit into from

Conversation

Xe
Copy link

@Xe Xe commented Feb 17, 2015

Some of my vim plugins and zsh tools were choking at the inconsistency.

@amark
Copy link
Owner

amark commented Feb 18, 2015

why does Travis say this failed? Nothing seems like it changed other than formatting.

@Xe
Copy link
Author

Xe commented Feb 18, 2015

It looks like a random failure to me.

@amark
Copy link
Owner

amark commented Feb 18, 2015

Hmm, this seems like it is NOT your problem, but mine.

v0.6.21 of Node is consistently failing on one of the tests.

Pulling.

@amark
Copy link
Owner

amark commented Feb 18, 2015

manually pulled, shouldn't github be intelligent enough to know that this is now pulled? Anyways, closing.

@amark amark closed this Feb 18, 2015
@alexlafroscia
Copy link
Contributor

Just curious, why are you using such an old version of Node?

@Xe Xe deleted the package-json/fix-spacing branch February 19, 2015 05:21
@amark
Copy link
Owner

amark commented Feb 19, 2015

Hey Alex! I was just thinking about you a few minutes ago. :) How are things going, school calming down? I got "groups" (finite sets/lists/collections) working finally, I had some nasty bugs I needed to fix.

I strive for maximal compatibility with most JS environments, since often the runtime is locked down by a vendor (aka schools running IE6 etc.) and not the choice of the user or developer.

However, I realized that doesn't really apply for NodeJS since you are the vendor, so I dropped Node v0.6 support. However, I still some day want to fix it, because the fact that it is consistently failing there suggests that there might be some more devious problem in my code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants