Add git to Dockerfile apks #1061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Git needs to be added to the docker image or the build fails at the npm install stage. _Looks at iris_ ... npm ERR! path git npm ERR! errno -2 npm ERR! enoent undefined ls-remote -h -t ssh://git@github.com/irislib/iris-messenger.git ...
|
This is a pretty important PR that should be merged asap, else you cant deploy to docker |
|
@MikePadge @manuel-777 merging... but why on earth does the old docker script need python and g++ stuff? It shouldn't need git either. Oh well, we can clean up later... thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Git needs to be added to the docker image or the build fails at the npm install stage.
Looks at iris